New issue
Advanced search Search tips

Issue 610950 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----



Sign in to add a comment

Save prompt shouldn't have FRE message

Project Member Reported by melandory@chromium.org, May 11 2016

Issue description

Smart Lock save prompt warm welcome on Clank shouldn't appear.
 
Summary: Save prompt shouldn't have FRE message (was: Safe prompt shouldn't have FRE message)
Labels: Merge-Request-51

Comment 4 by tin...@google.com, May 11 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 5 by bugdroid1@chromium.org, May 11 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36f3cfa21bda103c80d25f2455eaca2d0b9ceb2f

commit 36f3cfa21bda103c80d25f2455eaca2d0b9ceb2f
Author: Tatiana Gornak <melandory@chromium.org>
Date: Wed May 11 14:01:54 2016

[Smart Lock] Make save prompt first run experience never appear.

BUG= 610950 

Review-Url: https://codereview.chromium.org/1967983002
Cr-Commit-Position: refs/heads/master@{#392883}
(cherry picked from commit b065df589003a17094e96232455bc51f9515dad3)

Review URL: https://codereview.chromium.org/1966903003 .

Cr-Commit-Position: refs/branch-heads/2704@{#497}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/36f3cfa21bda103c80d25f2455eaca2d0b9ceb2f/components/password_manager/core/browser/password_bubble_experiment.cc
[modify] https://crrev.com/36f3cfa21bda103c80d25f2455eaca2d0b9ceb2f/components/password_manager/core/browser/password_bubble_experiment_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98e7c5bf360fe1a0db8c3e808798b81c23d5f038

commit 98e7c5bf360fe1a0db8c3e808798b81c23d5f038
Author: melandory <melandory@chromium.org>
Date: Thu Oct 27 10:03:38 2016

Ditch first run experience from Save Password Infobar

BUG= 610950 

Review-Url: https://codereview.chromium.org/2397743002
Cr-Commit-Position: refs/heads/master@{#427986}

[delete] https://crrev.com/0dfccfbdc3a54ae520ac87fe281f1cda0212a622/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
[modify] https://crrev.com/98e7c5bf360fe1a0db8c3e808798b81c23d5f038/chrome/android/java_sources.gni
[modify] https://crrev.com/98e7c5bf360fe1a0db8c3e808798b81c23d5f038/chrome/app/generated_resources.grd
[modify] https://crrev.com/98e7c5bf360fe1a0db8c3e808798b81c23d5f038/chrome/browser/BUILD.gn
[modify] https://crrev.com/98e7c5bf360fe1a0db8c3e808798b81c23d5f038/chrome/browser/password_manager/save_password_infobar_delegate_android.cc
[modify] https://crrev.com/98e7c5bf360fe1a0db8c3e808798b81c23d5f038/chrome/browser/password_manager/save_password_infobar_delegate_android.h
[modify] https://crrev.com/98e7c5bf360fe1a0db8c3e808798b81c23d5f038/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
[modify] https://crrev.com/98e7c5bf360fe1a0db8c3e808798b81c23d5f038/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/0dfccfbdc3a54ae520ac87fe281f1cda0212a622/chrome/browser/ui/android/infobars/save_password_infobar.cc
[delete] https://crrev.com/0dfccfbdc3a54ae520ac87fe281f1cda0212a622/chrome/browser/ui/android/infobars/save_password_infobar.h

Status: Fixed (was: Started)

Sign in to add a comment