New issue
Advanced search Search tips

Issue 610944 link

Starred by 1 user
Status: Fixed
Owner:
wychen@chromium.org
Closed: Aug 2016
Cc:
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Support native feature extraction in distillability modeling

Project Member Reported by wychen@chromium.org, May 11 2016 
Version: M51

In the training step of distillability modeling, we used JavaScript and python to extract the features. The logic of feature extraction was reimplemented in native code in https://codereview.chromium.org/1419033004. Exposing the features extracted by native code to the modeling script can help validate their equivalence, and also opens the possibility of using features not accessible by JavaScript.

Without supporting this, we'd have to maintain a local patch.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1730009565e394ff8c0ad04121d2e44d0c3d166

commit d1730009565e394ff8c0ad04121d2e44d0c3d166
Author: wychen <wychen@chromium.org>
Date: Fri Aug 12 23:10:17 2016

Roll DOM Distiller JavaScript distribution package

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/6c16f14405...91f9f016e0

Picked up changes:
91f9f01 Fix figcaption generation
365c44e Add support for figure element
f8f3308 Update distillability modeling scripts to predict long articles
8a12e18 Decrease mismatches in feature extraction
4d7ab13 Extract image URLs in WebTables
8d8063a Extract image URLs in srcset as well
34c4a18 Re-enable tests containing <track> in CI
0d4286b The display style of WebText root element should never be inline

BUG= 531545 ,539851, 595120 , 610944 , 613374 ,625621,631086, 637170 

Review-Url: https://codereview.chromium.org/2245763002
Cr-Commit-Position: refs/heads/master@{#411811}

[modify] https://crrev.com/d1730009565e394ff8c0ad04121d2e44d0c3d166/DEPS
[modify] https://crrev.com/d1730009565e394ff8c0ad04121d2e44d0c3d166/third_party/dom_distiller_js/README.chromium

Comment 2 by wychen@chromium.org, Aug 15 2016

Status: Fixed (was: Started)
►

Sign in to add a comment