New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610935 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
mus



Sign in to add a comment

[meta] Eliminate (or greatly simplify) components/mus/surfaces

Project Member Reported by fsam...@chromium.org, May 11 2016

Issue description

There's a lot of code in mus that can likely be dedup'ed with Chrome with a little bit of effort as part of the display_compositor refactor:

1. TopLevelDisplayClient => OnscreenDisplayClient
2. DirectOutputSurface/DirectOutputSurfaceOzone => SurfaceDisplayOutputSurface.
3. SurfacesContextProvider => InProcessContextProvider
 
Cc: jbau...@chromium.org
I had a chat with jbauman@. Mus probably still needs its own version of DisplayClient. I'm still going to refactor things out to a DisplayCompositor class, and make TopLevelDisplayClient more like OnscreenDisplayClient for consistency.
Project Member

Comment 2 by bugdroid1@chromium.org, May 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ae9b136bbf91f081db79870a0ceee7d88b78464

commit 4ae9b136bbf91f081db79870a0ceee7d88b78464
Author: fsamuel <fsamuel@chromium.org>
Date: Sat May 14 03:00:07 2016

Pull parts of TopLevelDisplayClient into DisplayCompositor

This CL starts to expose the beginnings of the API DisplayCompositor
should have:

SubmitCompositorFrame
RequestCopyOfOutput

TODO:

Hittest

TopLevelDisplayClient becomes a very thin implementation of
cc::DisplayClient and starts to resemble OnscreenDisplayClient.

BUG= 610937 ,  610935 

Review-Url: https://codereview.chromium.org/1976663003
Cr-Commit-Position: refs/heads/master@{#393731}

[modify] https://crrev.com/4ae9b136bbf91f081db79870a0ceee7d88b78464/components/mus/surfaces/BUILD.gn
[add] https://crrev.com/4ae9b136bbf91f081db79870a0ceee7d88b78464/components/mus/surfaces/display_compositor.cc
[add] https://crrev.com/4ae9b136bbf91f081db79870a0ceee7d88b78464/components/mus/surfaces/display_compositor.h
[modify] https://crrev.com/4ae9b136bbf91f081db79870a0ceee7d88b78464/components/mus/surfaces/top_level_display_client.cc
[modify] https://crrev.com/4ae9b136bbf91f081db79870a0ceee7d88b78464/components/mus/surfaces/top_level_display_client.h
[modify] https://crrev.com/4ae9b136bbf91f081db79870a0ceee7d88b78464/components/mus/ws/platform_display.cc
[modify] https://crrev.com/4ae9b136bbf91f081db79870a0ceee7d88b78464/components/mus/ws/platform_display.h
[modify] https://crrev.com/4ae9b136bbf91f081db79870a0ceee7d88b78464/components/mus/ws/server_window_surface_manager.cc

Labels: -mustash1 -mustash tadpole
Owner: fsam...@chromium.org
Status: Started (was: Untriaged)
fsamuel@ finished?
No, not even close :P
Components: Internals>MUS
Labels: Proj-Mustash
Blocking: 601863
Labels: Proj-Mustash-Mus Proj-Mustash-Mus-GPU
Status: Fixed (was: Started)
I think it's fair to call this bug finished at this point. Mus uses InProcessContextProvider now, and Mus has a lot less Mus-only code. There's a lot more code sharing now.
Blocking: -601863
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment