We need to decide what should happen when search is invoked from the Open tabs view.
If searching from the history page searches both history + synced tabs, can we just not show the search box in the synced tabs page?
Bumping to P1 as this is something we'll want to fix before we enable MD History by default.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f2348661c7b0fd695490cecbc4c3ef9f556b5df commit 9f2348661c7b0fd695490cecbc4c3ef9f556b5df Author: calamity <calamity@chromium.org> Date: Tue Jun 07 08:13:48 2016 [MD History] Add search for synced devices. This CL implements a simple search that matches the functionality of the original history page. This CL also fixes a bug related to window separators in the synced view that could cause excess window separators to appear. BUG= 610934 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2022003002 Cr-Commit-Position: refs/heads/master@{#398252} [modify] https://crrev.com/9f2348661c7b0fd695490cecbc4c3ef9f556b5df/chrome/browser/resources/md_history/app.html [modify] https://crrev.com/9f2348661c7b0fd695490cecbc4c3ef9f556b5df/chrome/browser/resources/md_history/history_item.js [modify] https://crrev.com/9f2348661c7b0fd695490cecbc4c3ef9f556b5df/chrome/browser/resources/md_history/synced_device_card.html [modify] https://crrev.com/9f2348661c7b0fd695490cecbc4c3ef9f556b5df/chrome/browser/resources/md_history/synced_device_card.js [modify] https://crrev.com/9f2348661c7b0fd695490cecbc4c3ef9f556b5df/chrome/browser/resources/md_history/synced_device_manager.html [modify] https://crrev.com/9f2348661c7b0fd695490cecbc4c3ef9f556b5df/chrome/browser/resources/md_history/synced_device_manager.js [modify] https://crrev.com/9f2348661c7b0fd695490cecbc4c3ef9f556b5df/chrome/test/data/webui/md_history/history_synced_tabs_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ffe3ea4196327e425b7b61ce9affd8cff393d8c commit 2ffe3ea4196327e425b7b61ce9affd8cff393d8c Author: calamity <calamity@chromium.org> Date: Thu Jun 16 06:39:09 2016 [MD History] Add history-searched-label to embolden the synced device search. This CL adds a history-searched-label element which bolds the given title wherever the given search term appears. This element is then used for the title of history-items and the title in the synced device search. BUG= 610934 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2046303002 Cr-Commit-Position: refs/heads/master@{#400095} [modify] https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c/chrome/browser/browser_resources.grd [modify] https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c/chrome/browser/resources/md_history/history_item.html [modify] https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c/chrome/browser/resources/md_history/history_item.js [add] https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c/chrome/browser/resources/md_history/searched_label.html [add] https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c/chrome/browser/resources/md_history/searched_label.js [modify] https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c/chrome/browser/resources/md_history/synced_device_card.html [modify] https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c/chrome/browser/resources/md_history/synced_device_card.js [modify] https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c/chrome/browser/resources/md_history/synced_device_manager.html [modify] https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c/chrome/browser/ui/webui/md_history_ui.cc [modify] https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c/chrome/test/data/webui/md_history/history_list_test.js [modify] https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c/chrome/test/data/webui/md_history/history_synced_tabs_test.js
Comment 1 by bettes@chromium.org
, May 11 2016