New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 610904 link

Starred by 1 user
Status: Fixed
Owner:
xhw...@chromium.org
Closed: May 2016
Cc:
█ w...@chromium.org
dalecur...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 0
Type: Bug



Sign in to add a comment

MojoCdmService::LegacyGetCdm fails to get the CDM

Project Member Reported by xhw...@chromium.org, May 11 2016 
Version: M52 ToT
OS: Android

Currently cdm_service is a source_set and is depended by both content and media/gpu. This is causing duplicate copies of some global variables like g_cdm_manager in mojo_cdm_service.cc. Note that ADVA was recently moved from content to media/gpu, which caused this issue to surface.

We should put cdm_service and other mojo media services into a component so that we don't have this issue.
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3b5d3f46840aba12d0788a14f14be9739712284

commit d3b5d3f46840aba12d0788a14f14be9739712284
Author: xhwang <xhwang@chromium.org>
Date: Wed May 18 03:37:59 2016

media: Make media mojo services a component

Previously media mojo services are in multiple small source_sets. This
was okay when they are only depended by one target (i.e. content). But
now we have multiple targets depending on them. For example, content and
media/gpu both depend on cdm_services. This causes duplicate definition
of some global veriables, e.g. g_cdm_manager in mojo_cdm_service.cc.

TBR=jam@chromium.org
BUG= 610904 
TEST=EME playback works.

Review-Url: https://codereview.chromium.org/1968833002
Cr-Commit-Position: refs/heads/master@{#394323}

[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/BUILD.gn
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/chrome/browser/BUILD.gn
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/chromecast/browser/media/BUILD.gn
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/content/gpu/BUILD.gn
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/content/gpu/gpu_process_control_impl.cc
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/content/shell/BUILD.gn
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/content/utility/BUILD.gn
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/content/utility/utility_process_control_impl.cc
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/media/gpu/BUILD.gn
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/media/mojo/BUILD.gn
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/media/mojo/services/BUILD.gn
[add] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/media/mojo/services/media_mojo_export.h
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/media/mojo/services/mojo_cdm_allocator.h
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/media/mojo/services/mojo_cdm_service.h
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/media/mojo/services/mojo_media_application.h
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/media/mojo/services/mojo_media_application_factory.h
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/media/mojo/services/mojo_media_client.h
[modify] https://crrev.com/d3b5d3f46840aba12d0788a14f14be9739712284/media/test/BUILD.gn

Comment 2 by xhw...@chromium.org, May 24 2016

Status: Fixed (was: Started)
►

Sign in to add a comment