New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610900 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocked on:
issue 594868

Blocking:
issue 352425
issue 591896
issue 610039



Sign in to add a comment

Remove the old (non-simplified) fullscreen bubble code on Views

Project Member Reported by mgiuca@chromium.org, May 11 2016

Issue description

Version: 52
OS: Windows, Linux, Chrome OS

The code for the "you have gone full screen" notification if you have chrome://flags/#simplified-fullscreen-ui disabled. We don't need this any more (as the flag has been flipped since M49 on Windows, Linux and Chrome OS). This would entail removing the flag on those platforms.

Note: Mac and Android would still have this flag (as it isn't fully flipped on those platforms yet). Neither of those platforms are using the old code, so there's no harm here. (tapted@: SG?)
 

Comment 1 by mgiuca@chromium.org, May 11 2016

Another perspective is that a number of people are using the Disabled state on this flag to work around  Issue 594868 . Perhaps we should keep the flag and the old code around until we have a solution to that.

Comment 2 by tapted@chromium.org, May 11 2016

Yah we should delete it. But first we need to port the old tests - a lot of these are disabled, so there will also be some effort to ensure they are not flaky. One on Mac wasn't disabled, and I paramaterized it to test both paths. We shouldn't just delete the old disabled tests when they no longer compile.

Comment 3 by mgiuca@chromium.org, May 11 2016

I'm also hesitant to delete the old code because recent discussions indicate that we'll be partly reverting towards the old model again (mouse to top of screen triggers the bubble, bubble contains clickable text) in response to  Issue 594868 .

Comment 4 by mgiuca@chromium.org, May 11 2016

I've updated  https://crbug.com/594868#c18  with a plan to delete most of the code while keeping the flag disableable for users who need to exit fullscreen with a mouse. This won't apply on Mac.

Comment 5 by mgiuca@chromium.org, May 12 2016

Blockedon: 594868

Comment 6 by mgiuca@chromium.org, May 12 2016

Blocking: 610039
Project Member

Comment 8 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90ed48601fd68e17b3cc3aa288c1926ef0fe675a

commit 90ed48601fd68e17b3cc3aa288c1926ef0fe675a
Author: mgiuca <mgiuca@chromium.org>
Date: Mon May 16 06:22:27 2016

Fullscreen / mouselock bubble: Use new theming even when flag disabled.

Only applies with simplified-fullscreen-ui flag disabled, and only on
Windows, Linux and Chrome OS.

Now the notification has:
- White-on-black, and transparent background.
- Always fade-in/out instead of slide-down/up.
- New-style padding.
- No message saying "<domain> has gone full screen".
- The new message with border around "Esc", except when there is a
  clickable link.

Basically, it now looks and behaves the same as with the flag enabled,
except that for fullscreen, you can hover the mouse to the top of the
screen to re-show the bubble, and there is a clickable link to get out
of fullscreen. This is a concession to allow for users without a
keyboard to escape fullscreen (until we can implement a better
solution).

Lots of code can now be deleted, but saving that for a follow-up.

BUG= 594868 , 610900 

Review-Url: https://codereview.chromium.org/1972543002
Cr-Commit-Position: refs/heads/master@{#393796}

[modify] https://crrev.com/90ed48601fd68e17b3cc3aa288c1926ef0fe675a/chrome/app/generated_resources.grd
[modify] https://crrev.com/90ed48601fd68e17b3cc3aa288c1926ef0fe675a/chrome/browser/ui/exclusive_access/exclusive_access_bubble.cc
[modify] https://crrev.com/90ed48601fd68e17b3cc3aa288c1926ef0fe675a/chrome/browser/ui/views/exclusive_access_bubble_views.cc

Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8fb109d29fa31626e110cbaed516a7b0de77d48

commit b8fb109d29fa31626e110cbaed516a7b0de77d48
Author: mgiuca <mgiuca@chromium.org>
Date: Tue May 17 02:27:35 2016

ExclusiveAccessBubbleViews: Remove unused code for old style.

We recently made the flag-disabled version work almost the same as the
flag-enabled version of the fullscreen bubble. This cleans up all the
dead code that is no longer used in either version.

BUG= 610900 

Review-Url: https://codereview.chromium.org/1971033003
Cr-Commit-Position: refs/heads/master@{#394023}

[modify] https://crrev.com/b8fb109d29fa31626e110cbaed516a7b0de77d48/chrome/browser/ui/views/exclusive_access_bubble_views.cc
[modify] https://crrev.com/b8fb109d29fa31626e110cbaed516a7b0de77d48/chrome/browser/ui/views/exclusive_access_bubble_views.h

Project Member

Comment 10 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a7f91857493839c1dd02f46984b956218d911c3

commit 1a7f91857493839c1dd02f46984b956218d911c3
Author: mgiuca <mgiuca@chromium.org>
Date: Fri May 27 02:12:44 2016

Remove the simplified-fullscreen-ui flag on Mac.

Now the flag is permanently enabled (which it already was by default).
Required so we can start removing the Cocoa code and we don't want to
have to add Mac-specific support for the non-simplified version on
Views.

BUG= 610900 

Review-Url: https://codereview.chromium.org/2012763005
Cr-Commit-Position: refs/heads/master@{#396355}

[modify] https://crrev.com/1a7f91857493839c1dd02f46984b956218d911c3/chrome/browser/about_flags.cc
[modify] https://crrev.com/1a7f91857493839c1dd02f46984b956218d911c3/chrome/browser/ui/exclusive_access/exclusive_access_manager.cc

Project Member

Comment 11 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96345e63d03712e55fb306eef268265109a177e9

commit 96345e63d03712e55fb306eef268265109a177e9
Author: mgiuca <mgiuca@chromium.org>
Date: Fri May 27 04:43:36 2016

Mac: Start removing Cocoa fullscreen code.

Previously, the simplified-fullscreen-ui flag controlled whether to use
the new Views fullscreen notification bubble, or the old Cocoa one. Now
that this flag has been removed on Mac, the Cocoa bubble code is no
longer used. This change should have no visible effect.

BUG= 610900 

Review-Url: https://codereview.chromium.org/2001423002
Cr-Commit-Position: refs/heads/master@{#396393}

[modify] https://crrev.com/96345e63d03712e55fb306eef268265109a177e9/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h
[modify] https://crrev.com/96345e63d03712e55fb306eef268265109a177e9/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
[modify] https://crrev.com/96345e63d03712e55fb306eef268265109a177e9/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm
[modify] https://crrev.com/96345e63d03712e55fb306eef268265109a177e9/chrome/browser/ui/exclusive_access/exclusive_access_bubble.cc

Project Member

Comment 12 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa0624b7820466acef41ff00487970b1cbcd6f01

commit fa0624b7820466acef41ff00487970b1cbcd6f01
Author: mgiuca <mgiuca@chromium.org>
Date: Tue May 31 03:34:38 2016

Remove Mac Cocoa fullscreen prompt.

This was no longer used (in favour of the Views fullscreen prompt).
Removes ExclusiveAccessBubble.xib, along with classes
ExclusiveAccessBubbleView and ExclusiveAccessBubbleWindowController.

BUG= 610900 

Review-Url: https://codereview.chromium.org/2001103003
Cr-Commit-Position: refs/heads/master@{#396777}

[modify] https://crrev.com/fa0624b7820466acef41ff00487970b1cbcd6f01/chrome/app/generated_resources.grd
[modify] https://crrev.com/fa0624b7820466acef41ff00487970b1cbcd6f01/chrome/app/nibs/BUILD.gn
[delete] https://crrev.com/24873c03c01a5e4fb30b2b32988f1f63e8ce1855/chrome/app/nibs/ExclusiveAccessBubble.xib
[modify] https://crrev.com/fa0624b7820466acef41ff00487970b1cbcd6f01/chrome/browser/ui/cocoa/browser_window_controller.h
[delete] https://crrev.com/24873c03c01a5e4fb30b2b32988f1f63e8ce1855/chrome/browser/ui/cocoa/exclusive_access_bubble_view.h
[delete] https://crrev.com/24873c03c01a5e4fb30b2b32988f1f63e8ce1855/chrome/browser/ui/cocoa/exclusive_access_bubble_view.mm
[delete] https://crrev.com/24873c03c01a5e4fb30b2b32988f1f63e8ce1855/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.h
[delete] https://crrev.com/24873c03c01a5e4fb30b2b32988f1f63e8ce1855/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm
[delete] https://crrev.com/24873c03c01a5e4fb30b2b32988f1f63e8ce1855/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm
[modify] https://crrev.com/fa0624b7820466acef41ff00487970b1cbcd6f01/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/fa0624b7820466acef41ff00487970b1cbcd6f01/chrome/chrome_nibs.gyp
[modify] https://crrev.com/fa0624b7820466acef41ff00487970b1cbcd6f01/chrome/chrome_nibs.gypi
[modify] https://crrev.com/fa0624b7820466acef41ff00487970b1cbcd6f01/chrome/chrome_tests_unit.gypi

Project Member

Comment 13 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a47af6863779505af7776102bc5390234a985476

commit a47af6863779505af7776102bc5390234a985476
Author: mgiuca <mgiuca@chromium.org>
Date: Wed Jun 08 01:24:02 2016

Remove the simplified-fullscreen-ui flag on Android.

Now the flag is permanently enabled. Cleaned up some code that is no
longer used because of this change. The FullscreenInfoBarDelegate class
is no longer used but this will be deleted in a follow-up CL.

BUG= 610900 

Review-Url: https://codereview.chromium.org/2008813002
Cr-Commit-Position: refs/heads/master@{#398448}

[modify] https://crrev.com/a47af6863779505af7776102bc5390234a985476/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java
[modify] https://crrev.com/a47af6863779505af7776102bc5390234a985476/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenInfoBarDelegate.java
[modify] https://crrev.com/a47af6863779505af7776102bc5390234a985476/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java
[modify] https://crrev.com/a47af6863779505af7776102bc5390234a985476/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/a47af6863779505af7776102bc5390234a985476/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/a47af6863779505af7776102bc5390234a985476/chrome/browser/about_flags.cc
[modify] https://crrev.com/a47af6863779505af7776102bc5390234a985476/chrome/common/chrome_features.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6adb5143ab0cc79a64c64a42f965bbc595ab14c

commit b6adb5143ab0cc79a64c64a42f965bbc595ab14c
Author: mgiuca <mgiuca@chromium.org>
Date: Wed Jun 08 08:41:33 2016

Delete unused code for exclusive access permission prompting.

On all platforms and flag configurations (except Android, which is not
covered in this CL), we no longer prompt for fullscreen / mouse lock
permission. Therefore, all of the prompting infrastructure is dead code
and can now be safely deleted. This change should not have any
observable effect.

BUG= 610900 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2004353002
Cr-Commit-Position: refs/heads/master@{#398504}

[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/app/generated_resources.grd
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/exclusive_access_bubble.cc
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/exclusive_access_bubble.h
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/exclusive_access_bubble_type.cc
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/exclusive_access_bubble_type.h
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/exclusive_access_manager.cc
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/exclusive_access_manager.h
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/fullscreen_controller.cc
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/fullscreen_controller.h
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.cc
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.h
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/fullscreen_controller_state_tests.h
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/fullscreen_controller_test.cc
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/fullscreen_controller_test.h
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/mouse_lock_controller.cc
[modify] https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c/chrome/browser/ui/exclusive_access/mouse_lock_controller.h

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6da50af4580380fbf35d7d425178dc3dc853263

commit e6da50af4580380fbf35d7d425178dc3dc853263
Author: mgiuca <mgiuca@chromium.org>
Date: Thu Jun 09 01:16:01 2016

Remove (already-hidden) global fullscreen / mouselock settings.

This UI was already hidden. This just removes the HTML code for those
radio buttons, as well as the unused code for showing these buttons, and
the strings.

BUG= 610900 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2045163002
Cr-Commit-Position: refs/heads/master@{#398757}

[modify] https://crrev.com/e6da50af4580380fbf35d7d425178dc3dc853263/chrome/app/generated_resources.grd
[modify] https://crrev.com/e6da50af4580380fbf35d7d425178dc3dc853263/chrome/browser/resources/options/content_settings.html
[modify] https://crrev.com/e6da50af4580380fbf35d7d425178dc3dc853263/chrome/browser/resources/options/content_settings.js
[modify] https://crrev.com/e6da50af4580380fbf35d7d425178dc3dc853263/chrome/browser/ui/webui/options/content_settings_handler.cc

Blocking: 591896
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3414c8d814838b3ef60a58ca3503a80ba74777d1

commit 3414c8d814838b3ef60a58ca3503a80ba74777d1
Author: mgiuca <mgiuca@chromium.org>
Date: Fri Jun 17 05:40:23 2016

Delete FullscreenInfoBarDelegate class.

This was previously used to display the fullscreen entry prompt on
Android, but is no longer used.

BUG= 610900 

Review-Url: https://codereview.chromium.org/2007833002
Cr-Commit-Position: refs/heads/master@{#400367}

[delete] https://crrev.com/e52c57c45bbbba429f1c1040097ad21df5646ed9/chrome/android/java/res/drawable-hdpi/infobar_fullscreen.png
[delete] https://crrev.com/e52c57c45bbbba429f1c1040097ad21df5646ed9/chrome/android/java/res/drawable-mdpi/infobar_fullscreen.png
[delete] https://crrev.com/e52c57c45bbbba429f1c1040097ad21df5646ed9/chrome/android/java/res/drawable-xhdpi/infobar_fullscreen.png
[delete] https://crrev.com/e52c57c45bbbba429f1c1040097ad21df5646ed9/chrome/android/java/res/drawable-xxhdpi/infobar_fullscreen.png
[delete] https://crrev.com/e52c57c45bbbba429f1c1040097ad21df5646ed9/chrome/android/java/res/drawable-xxxhdpi/infobar_fullscreen.png
[delete] https://crrev.com/e52c57c45bbbba429f1c1040097ad21df5646ed9/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenInfoBarDelegate.java
[modify] https://crrev.com/3414c8d814838b3ef60a58ca3503a80ba74777d1/chrome/android/java_sources.gni
[modify] https://crrev.com/3414c8d814838b3ef60a58ca3503a80ba74777d1/chrome/app/generated_resources.grd
[modify] https://crrev.com/3414c8d814838b3ef60a58ca3503a80ba74777d1/chrome/browser/android/chrome_jni_registrar.cc
[delete] https://crrev.com/e52c57c45bbbba429f1c1040097ad21df5646ed9/chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc
[delete] https://crrev.com/e52c57c45bbbba429f1c1040097ad21df5646ed9/chrome/browser/android/fullscreen/fullscreen_infobar_delegate.h
[modify] https://crrev.com/3414c8d814838b3ef60a58ca3503a80ba74777d1/chrome/browser/android/resource_id.h
[modify] https://crrev.com/3414c8d814838b3ef60a58ca3503a80ba74777d1/chrome/chrome_browser.gypi
[modify] https://crrev.com/3414c8d814838b3ef60a58ca3503a80ba74777d1/components/infobars/core/infobar_delegate.h

Project Member

Comment 19 by sheriffbot@chromium.org, Jul 10 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/273b9672cfbf83ffed8f52a91cb59a6e78a64577

commit 273b9672cfbf83ffed8f52a91cb59a6e78a64577
Author: mgiuca <mgiuca@chromium.org>
Date: Fri Nov 11 02:22:20 2016

Deleted CONTENT_SETTINGS_TYPE_FULLSCREEN and MOUSELOCK.

Fullscreen and mouselock content settings have not been used for some
time. The pref data was recently deleted and now all code associated
with these settings is vestigial.

BUG= 591896 , 610900 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2419413002
Cr-Commit-Position: refs/heads/master@{#431465}

[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/content_settings/host_content_settings_map_unittest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/extensions/api/content_settings/content_settings_store.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/resources/settings/site_settings/site_settings_category.js
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/website_settings/permission_menu_model.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/website_settings/website_settings.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/website_settings/website_settings_ui.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/website_settings/website_settings_unittest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/test/ppapi/ppapi_interactive_browsertest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/components/content_settings/core/browser/content_settings_default_provider.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/components/content_settings/core/browser/content_settings_pref_provider.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/components/content_settings/core/browser/content_settings_registry.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/components/content_settings/core/common/content_settings.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/components/content_settings/core/common/content_settings_types.h
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/ppapi/tests/test_mouse_lock.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/ppapi/tests/test_mouse_lock.h
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/tools/metrics/actions/actions.xml
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/tools/metrics/histograms/histograms.xml

Cc: chongz@chromium.org
In a code review I noticed this code is still around. From top of mind do we
a) Know this code is ready to be pulled out.
b) Know there are still some blockers.
c) Not know for sure, this issue would need investigating (maybe not a priority to do that now).
I think (a). We were blocked on the fact that people were relying on the old flag for mouse-only support, but we made an Executive Decision to drop that. So we can remove it. I just have a lot of things going on right now.
Cc: mgiuca@chromium.org
Owner: dtapu...@chromium.org
Assigning to dtapuska who has made a CL for this:
https://chromium-review.googlesource.com/c/chromium/src/+/1037843
Project Member

Comment 24 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bc63faa0206e48e08def995f7d1ea03c50e56bd

commit 3bc63faa0206e48e08def995f7d1ea03c50e56bd
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed May 02 19:25:45 2018

Remove ViewsSimplifiedFullscreenUI setting.

Appears this feature shipped roughly 2 years ago in M51. Remove old
supporting code that isn't needed anymore.

BUG= 610900 

Change-Id: I121dd3da84ab2ca963bb87a47343972a9ba794c4
Reviewed-on: https://chromium-review.googlesource.com/1037843
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555500}
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/about_flags.cc
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/ui/exclusive_access/exclusive_access_bubble.cc
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/ui/exclusive_access/exclusive_access_manager.cc
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/ui/exclusive_access/exclusive_access_manager.h
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/ui/views/exclusive_access_bubble_views.cc
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/ui/views/exclusive_access_bubble_views.h
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/ui/views/subtle_notification_view.cc
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/browser/ui/views/subtle_notification_view.h
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/common/chrome_features.cc
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/chrome/common/chrome_features.h
[modify] https://crrev.com/3bc63faa0206e48e08def995f7d1ea03c50e56bd/testing/variations/fieldtrial_testing_config.json

Status: Fixed (was: Assigned)
Thanks for doing this!

Sign in to add a comment