New issue
Advanced search Search tips

Issue 610892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 2
Type: Bug



Sign in to add a comment

Spitzer doesn't support hardware decoding for > 1080p VP8, VP9 content.

Project Member Reported by dalecur...@chromium.org, May 11 2016

Issue description

No reason to preclude this, since media player would have tried. Tying to a bug in case we want to merge back for M51 for some reason.
 
Labels: -M-52 -Pri-3 Proj-Spitzer M-51 Pri-2
Actually there are a couple devices like the S7 and Pixel C which can play this content, so we should make it work with Spitzer on M51 since it's a trivial change.
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e699bc922e00aec59d2aba8e62dbe88e615f011

commit 1e699bc922e00aec59d2aba8e62dbe88e615f011
Author: dalecurtis <dalecurtis@chromium.org>
Date: Wed May 11 01:17:51 2016

Bump hardware decoding limits to 4k.

Devices like the S6+ can decode 4k content. If a device fails to
configure we'll just fallback to software anyways.

BUG= 610892 
TEST=samsung s6 plays hardware vp8/vp9

Review-Url: https://codereview.chromium.org/1963413002
Cr-Commit-Position: refs/heads/master@{#392805}

[modify] https://crrev.com/1e699bc922e00aec59d2aba8e62dbe88e615f011/media/gpu/android_video_decode_accelerator.cc

Will let this soak until next dev and merge.
Labels: Merge-Request-51
Looks good.

Comment 5 by tin...@google.com, May 16 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 6 by gov...@chromium.org, May 16 2016

Please merge your change to M51 branch 2704 before 5:00 PM PST today, Monday so we can take it for this week beta release. Thank you.
Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, May 16 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae3ad94d0a63499be2c02681d8cbfb0e156e021d

commit ae3ad94d0a63499be2c02681d8cbfb0e156e021d
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Mon May 16 20:51:09 2016

Merge M51: "Bump hardware decoding limits to 4k."

Devices like the S6+ can decode 4k content. If a device fails to
configure we'll just fallback to software anyways.

BUG= 610892 
TEST=samsung s6 plays hardware vp8/vp9

(cherry picked from commit 015716d3d99240e00ae548df4927b1e1a105359f)

Review URL: https://codereview.chromium.org/1987453002 .

Cr-Commit-Position: refs/branch-heads/2704@{#564}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/ae3ad94d0a63499be2c02681d8cbfb0e156e021d/content/common/gpu/media/android_video_decode_accelerator.cc

Sign in to add a comment