New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610889 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 611658
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

fast/text/emphasis.html always fails on win_chromium_rel_ng

Project Member Reported by jbroman@chromium.org, May 10 2016

Issue description

This makes the bot always have to build without patch to check if the test fails on both sides.

Looks like it just needs rebaselining.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/060e789bbabb56cb5a11e0a73e70256bc6b768ac

commit 060e789bbabb56cb5a11e0a73e70256bc6b768ac
Author: jbroman <jbroman@chromium.org>
Date: Wed May 11 16:20:33 2016

Rebaseline fast/text/emphasis.html on Windows.

BUG= 610889 

Review-Url: https://codereview.chromium.org/1965173002
Cr-Commit-Position: refs/heads/master@{#392946}

[modify] https://crrev.com/060e789bbabb56cb5a11e0a73e70256bc6b768ac/third_party/WebKit/LayoutTests/TestExpectations

Cc: jbroman@chromium.org
Owner: wkorman@chromium.org
Uh, what? The rebaseline bot didn't do anything. Does this mean that this page actually renders differently on the trybots and waterfall bots (which is what I think the rebaseline bot pulls from)?

wkorman, do you know what's up here?
Yeah, your explanation is possible. The bot does pull from the waterfall bots.

The trybots build with dcheck_always_on which can lead to debug differences as I understand it. There can be other build/runtime flag differences. I can look at this on Tue.
Cc: roc...@chromium.org liber...@chromium.org
See also https://codereview.chromium.org/1974373002/ where there is some discussion on Windows baselines not seeming right, in case it's related.
FWIW, summary of https://codereview.chromium.org/1974373002/ is:

- rebaseline fonts look wrong in the images
- trybot fonts look right
- canary on my home win7 looks right (these changes went in via experiment earlier)
See more font discussion in http://crbug.com/487344#c31 and below.

Comment 8 by sshru...@google.com, May 18 2016

Labels: Test-Layout

Comment 9 by sshru...@google.com, May 18 2016

Components: -Blink>LayoutTests
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead.
Mergedinto: 611658
Status: Duplicate (was: Started)

Sign in to add a comment