New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610872 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 610877



Sign in to add a comment

PageSize histograms have a minimum of 1000 KB

Project Member Reported by dewittj@chromium.org, May 10 2016

Issue description

If pages are less than 1000 KB, then they will be reported as 1000KB, skewing our results.

Affected histograms:

OfflinePages.BatchDelete.TotalPageSize
OfflinePages.DeletePage.PageSize
OfflinePages.PageSize
 
Components: UI>Browser>Offline
Blocking: 610877
Owner: jianli@chromium.org
Status: Assigned (was: Untriaged)
Could you make sure that we are not hitting some histogram resolution problems. Perhaps we should not be dividing by 1024 and that is how this is meant to work?
Labels: -Pri-3 Pri-2
This metric is recorded correctly, just the histogram is defined poorly for our purposes.  We may need a custom counts histogram to get exactly the data we wand.

Comment 5 by dim...@chromium.org, May 18 2016

Owner: dim...@chromium.org
Status: Started (was: Assigned)
Stealing from Jian
Project Member

Comment 6 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36d2aa2331eb458d324ac60b628abf721b8750f4

commit 36d2aa2331eb458d324ac60b628abf721b8750f4
Author: dimich <dimich@chromium.org>
Date: Thu May 19 01:51:51 2016

Change UMA OfflinePages.PageSize to have better resolution in a typical range of offline page sizes.

BUG= 610872 

Review-Url: https://codereview.chromium.org/1989733002
Cr-Commit-Position: refs/heads/master@{#394634}

[modify] https://crrev.com/36d2aa2331eb458d324ac60b628abf721b8750f4/components/offline_pages/offline_page_model.cc

Does the metrics system support changing histogram buckets on the fly for a given metric?

Comment 8 by dim...@chromium.org, Aug 29 2016

Status: Fixed (was: Started)
#7: Yes, in a sense that if a specific timeframe specified for a query, you get a new distribution after the new bits roll out.

Sign in to add a comment