Offline free space histograms not recorded unless page is saved with Java OfflinePageBridge |
||||||
Issue descriptionhttps://code.google.com/p/chromium/codesearch#search/&q=OfflinePages.SavePage.FreeSpacePercentage The above search reveals that FreeSpacePercentage doesn't appear in C++ which means that the recent page helper won't record this metric.
,
May 10 2016
The following histograms are affected: "OfflinePages.SavePage.FreeSpacePercentage" "OfflinePages.SavePage.FreeSpaceMB" "OfflinePages.DeletePage.FreeSpacePercentage" "OfflinePages.DeletePage.FreeSpaceMB"
,
May 10 2016
,
May 11 2016
Please include this work in storage management effort.
,
May 17 2016
I am looking at this.
,
May 17 2016
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dd3fa4cec92adb64af5e4a484bcd27074d60b4a commit 1dd3fa4cec92adb64af5e4a484bcd27074d60b4a Author: fgorski <fgorski@chromium.org> Date: Wed May 18 22:00:55 2016 [Offline pages] Moving disk size related calls to Archive Manager, reorganizing UMA * Obsoletes 3 offline page UMAs * Moves UMA reporting and triggers for saving/deleting pages to model * Adds capability to get free space and total page size to ArchiveManager BUG= 610870 Review-Url: https://codereview.chromium.org/1988973002 Cr-Commit-Position: refs/heads/master@{#394566} [modify] https://crrev.com/1dd3fa4cec92adb64af5e4a484bcd27074d60b4a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java [modify] https://crrev.com/1dd3fa4cec92adb64af5e4a484bcd27074d60b4a/chrome/browser/android/offline_pages/offline_page_bridge.cc [modify] https://crrev.com/1dd3fa4cec92adb64af5e4a484bcd27074d60b4a/chrome/browser/android/offline_pages/offline_page_bridge.h [modify] https://crrev.com/1dd3fa4cec92adb64af5e4a484bcd27074d60b4a/components/offline_pages/archive_manager.cc [modify] https://crrev.com/1dd3fa4cec92adb64af5e4a484bcd27074d60b4a/components/offline_pages/archive_manager.h [modify] https://crrev.com/1dd3fa4cec92adb64af5e4a484bcd27074d60b4a/components/offline_pages/archive_manager_unittest.cc [modify] https://crrev.com/1dd3fa4cec92adb64af5e4a484bcd27074d60b4a/components/offline_pages/offline_page_model.cc [modify] https://crrev.com/1dd3fa4cec92adb64af5e4a484bcd27074d60b4a/components/offline_pages/offline_page_model.h [modify] https://crrev.com/1dd3fa4cec92adb64af5e4a484bcd27074d60b4a/tools/metrics/histograms/histograms.xml
,
May 18 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dewittj@chromium.org
, May 10 2016