OfflinePages.SavePageResult needs a suffix |
|||||
Issue descriptionhttps://code.google.com/p/chromium/codesearch#search/&sq=package:chromium&type=cs&q=OfflinePages.SavePageResult The linked search shows that we are recording OfflinePages.SavePageResult in multiple places. I believe that we are double-counting pages saved using the savePage API call. Currently only cached bookmarks are affected.
,
May 11 2016
,
May 16 2016
I just realized that this is not a duplicate, as it only happens when webContents is destroyed and reports a failure to save a page. Assigning to Jian Li.
,
May 16 2016
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29952fa90b04d34ea92914ee3eeea1daf8e90c55 commit 29952fa90b04d34ea92914ee3eeea1daf8e90c55 Author: jianli <jianli@chromium.org> Date: Wed May 18 03:23:41 2016 Update offline pages UMAs 1) Mark some UMAs that were removed some time ago, as obsolete 2) Append client namespace suffix to some UMAs 3) Add a new UMA BUG= 610877 , 610869 Review-Url: https://codereview.chromium.org/1980623003 Cr-Commit-Position: refs/heads/master@{#394322} [modify] https://crrev.com/29952fa90b04d34ea92914ee3eeea1daf8e90c55/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java [modify] https://crrev.com/29952fa90b04d34ea92914ee3eeea1daf8e90c55/chrome/browser/android/offline_pages/offline_page_bridge.cc [modify] https://crrev.com/29952fa90b04d34ea92914ee3eeea1daf8e90c55/chrome/browser/android/offline_pages/offline_page_tab_helper.cc [modify] https://crrev.com/29952fa90b04d34ea92914ee3eeea1daf8e90c55/components/offline_pages/offline_page_model.cc [modify] https://crrev.com/29952fa90b04d34ea92914ee3eeea1daf8e90c55/components/offline_pages/offline_page_model.h [modify] https://crrev.com/29952fa90b04d34ea92914ee3eeea1daf8e90c55/tools/metrics/histograms/histograms.xml
,
May 18 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dewittj@chromium.org
, May 10 2016