MediaCodec requires AudioDecoderConfig extra_data to be populated for AAC. We do this already for MP4 [0] and MP2-TS [1], but not yet for ADTS. Once added for ADTS, we should remove the test code that inserts it [2]. [0]https://code.google.com/p/chromium/codesearch#chromium/src/media/formats/mp4/mp4_stream_parser.cc&sq=package:chromium&type=cs&q=extra_data%20file:%5Esrc/media/formats/mp4/&l=284 [1]https://code.google.com/p/chromium/codesearch#chromium/src/media/formats/mp2t/es_parser_adts.cc&l=180 [2]https://code.google.com/p/chromium/codesearch#chromium/src/media/filters/audio_decoder_unittest.cc&sq=package:chromium&type=cs&q=audio_decoder_unittest&l=207
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7f5facc5a9b7c6d04206a413c88dbafade336c1 commit b7f5facc5a9b7c6d04206a413c88dbafade336c1 Author: dalecurtis <dalecurtis@chromium.org> Date: Thu Sep 29 20:06:56 2016 Fix MSE ADTS parsing on Android. Android needs the extra_data fields in order to playback ADTS content, so fill them in only on Android. BUG= 610848 , 650735 TEST=http://storage.googleapis.com/chcunningham-chrome-shared/534301/aac_test.html Review-Url: https://codereview.chromium.org/2378443002 Cr-Commit-Position: refs/heads/master@{#421913} [modify] https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1/media/BUILD.gn [modify] https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1/media/filters/audio_decoder_unittest.cc [modify] https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1/media/formats/mp2t/es_parser_adts.cc [modify] https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1/media/formats/mp2t/es_parser_adts.h [delete] https://crrev.com/ecc7bb5f24660afd661d27a4430b057b2c453387/media/formats/mpeg/adts_header_parser.cc [delete] https://crrev.com/ecc7bb5f24660afd661d27a4430b057b2c453387/media/formats/mpeg/adts_header_parser.h [modify] https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1/media/formats/mpeg/adts_stream_parser.cc [modify] https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1/media/formats/mpeg/adts_stream_parser.h [modify] https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1/media/formats/mpeg/mpeg1_audio_stream_parser.cc [modify] https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1/media/formats/mpeg/mpeg1_audio_stream_parser.h [modify] https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1/media/formats/mpeg/mpeg_audio_stream_parser_base.cc [modify] https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1/media/formats/mpeg/mpeg_audio_stream_parser_base.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c27e432072ef22112251bbe874c8a1060a0c7ca5 commit c27e432072ef22112251bbe874c8a1060a0c7ca5 Author: dalecurtis <dalecurtis@chromium.org> Date: Fri Sep 30 19:34:39 2016 Fix media_log() crash in fuzzer tests. When called from this context, no MediaLog exists, so ensure we don't try to use it. BUG= 610848 , 650735 , 651739 TEST=libfuzzer Review-Url: https://codereview.chromium.org/2388443002 Cr-Commit-Position: refs/heads/master@{#422182} [modify] https://crrev.com/c27e432072ef22112251bbe874c8a1060a0c7ca5/media/formats/mpeg/adts_stream_parser.cc
Comment 1 by chcunningham@chromium.org
, Aug 18 2016