New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610839 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 614024



Sign in to add a comment

turn down "Android GN" bots on chromium.linux

Project Member Reported by jbudorick@chromium.org, May 10 2016

Issue description

All android bots are now on GN, so Android GN and Android GN (dbg) are unnecessary. We should move any suites that Android GN runs over to Android Tests, then turn down Android GN, Android GN (dbg), android_chromium_gn_compile_dbg, and android_chromium_gn_compile_rel.
 

Comment 1 by stip@chromium.org, May 12 2016

Owner: stip@chromium.org
Status: Assigned (was: Untriaged)
I can take this.
Labels: -Pri-2 Pri-1
let's do this sooner rather than later

Comment 3 by stip@chromium.org, May 16 2016

Are these breaking things?
They're flaking in ways that don't match the other bots.
(afaict, the only difference is the OS version -- K MR1 here vs K MR2 elsewhere)
Cc: stip@chromium.org
Owner: jbudorick@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59eabd3c7b1ea533decb267a4f06785124e0208d

commit 59eabd3c7b1ea533decb267a4f06785124e0208d
Author: jbudorick <jbudorick@chromium.org>
Date: Thu May 19 15:08:09 2016

[Android] Disable death check in BindingCallbackTest.DeleteCallbackBeforeBindingDeathTest.

The Android bot this previously ran on, Android GN, did release builds without
DCHECK_ALWAYS_ON, so the death check was being skipped anyway.

BUG= 610839 

Review-Url: https://codereview.chromium.org/1991233002
Cr-Commit-Position: refs/heads/master@{#394770}

[modify] https://crrev.com/59eabd3c7b1ea533decb267a4f06785124e0208d/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc

Issue 611483 has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0daa70eae2543b93f14edf029e91ed72129b3e2f

commit 0daa70eae2543b93f14edf029e91ed72129b3e2f
Author: jbudorick <jbudorick@chromium.org>
Date: Thu May 19 20:47:53 2016

[Android] Move test suites from Android GN over to Android Tests{, (dbg)}.

This includes:
 - ipc_mojo_unittests
 - mojo_common_unittests
 - mojo_public_application_unittests
 - mojo_public_bindings_unittests
 - mojo_public_system_unittests
 - mojo_runner_host_unittests
 - mojo_surfaces_lib_unittests

BUG= 610839 

Review-Url: https://codereview.chromium.org/1988023007
Cr-Commit-Position: refs/heads/master@{#394855}

[modify] https://crrev.com/0daa70eae2543b93f14edf029e91ed72129b3e2f/testing/buildbot/chromium.linux.json

Project Member

Comment 11 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ae7a77b041af74734d2a790ae3931d798da6887

commit 3ae7a77b041af74734d2a790ae3931d798da6887
Author: jbudorick <jbudorick@chromium.org>
Date: Fri May 20 02:36:04 2016

[Android] Remove android_chromium_gn_compile_{dbg,rel} from the CQ.

BUG= 610839 

Review-Url: https://codereview.chromium.org/1998693002
Cr-Commit-Position: refs/heads/master@{#394963}

[modify] https://crrev.com/3ae7a77b041af74734d2a790ae3931d798da6887/PRESUBMIT_test.py
[modify] https://crrev.com/3ae7a77b041af74734d2a790ae3931d798da6887/infra/config/cq.cfg

Project Member

Comment 12 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/9787bd7b6efc5931d240a979ff3b1250da038070

commit 9787bd7b6efc5931d240a979ff3b1250da038070
Author: jbudorick <jbudorick@chromium.org>
Date: Mon May 23 14:10:11 2016

[Android] Turn down gn-specific Android bots.

All Android bots are now on GN, so there's no longer a reason for these
to exist.

BUG= 610839 

Review-Url: https://codereview.chromium.org/1996053002

[modify] https://crrev.com/9787bd7b6efc5931d240a979ff3b1250da038070/masters/master.chromium.android/builders.pyl
[modify] https://crrev.com/9787bd7b6efc5931d240a979ff3b1250da038070/masters/master.chromium.linux/master_android_cfg.py
[modify] https://crrev.com/9787bd7b6efc5931d240a979ff3b1250da038070/masters/master.chromium.linux/slaves.cfg
[modify] https://crrev.com/9787bd7b6efc5931d240a979ff3b1250da038070/masters/master.tryserver.chromium.android/builders.pyl
[modify] https://crrev.com/9787bd7b6efc5931d240a979ff3b1250da038070/scripts/slave/recipe_modules/chromium_tests/chromium_android.py
[modify] https://crrev.com/9787bd7b6efc5931d240a979ff3b1250da038070/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py
[modify] https://crrev.com/9787bd7b6efc5931d240a979ff3b1250da038070/scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md
[modify] https://crrev.com/9787bd7b6efc5931d240a979ff3b1250da038070/scripts/slave/recipe_modules/chromium_tests/trybots.py
[delete] https://crrev.com/6a177e143a697d6a72029c9d50cd73d5c5ee7281/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_GN_Builder__dbg_.json
[delete] https://crrev.com/6a177e143a697d6a72029c9d50cd73d5c5ee7281/scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_GN.json
[delete] https://crrev.com/6a177e143a697d6a72029c9d50cd73d5c5ee7281/scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_GN__dbg_.json
[delete] https://crrev.com/6a177e143a697d6a72029c9d50cd73d5c5ee7281/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_chromium_gn_compile_dbg.json
[delete] https://crrev.com/6a177e143a697d6a72029c9d50cd73d5c5ee7281/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_chromium_gn_compile_rel.json
[delete] https://crrev.com/6a177e143a697d6a72029c9d50cd73d5c5ee7281/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_chromium_gn_rel.json

Blocking: 614024
Project Member

Comment 14 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/bcd7af96f3023f3a2b5841ccd195b6bd48048b76

commit bcd7af96f3023f3a2b5841ccd195b6bd48048b76
Author: jbudorick <jbudorick@google.com>
Date: Mon May 23 14:21:29 2016

Status: Fixed (was: Started)
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 17 2016

Sign in to add a comment