Issue metadata
Sign in to add a comment
|
[Media Router] No Cast media controls for remote media routes |
||||||||||||||||||||||
Issue descriptionVersion: 52.0.2723.3 OS: All What steps will reproduce the problem? (1) Enable Media Router w/a Cast device (2) Mirror an website from another instance of Chrome on the same network What is the expected output? Selecting the active Cast device shows media controls. What do you see instead? No media controls. Problem: https://codereview.chromium.org/1911183002 shortcuts Media Router JoinRoute() calls for non-local routes to optimize event page usage. However, Cast relies on this use case for its custom media controls.
,
May 10 2016
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ae252e8c2280bacd2d75c280dc0440f97277e37 commit 0ae252e8c2280bacd2d75c280dc0440f97277e37 Author: mfoltz <mfoltz@chromium.org> Date: Thu May 12 19:30:55 2016 [MediaRouter] Update JoinRoute behavior to allow non-local routes. Change https://codereview.chromium.org/1911183002 rejects JoinRoute requests when there are no local routes. This breaks certain use cases for Cast. This relaxes the check to forward requests to the MRPM when there is any route (local or non-local). Long term, individual routes should be marked joinable or non-joinable so the optimization can be made precise. BUG= 610797 Review-Url: https://codereview.chromium.org/1971893002 Cr-Commit-Position: refs/heads/master@{#393330} [modify] https://crrev.com/0ae252e8c2280bacd2d75c280dc0440f97277e37/chrome/browser/media/router/media_router_base.cc [modify] https://crrev.com/0ae252e8c2280bacd2d75c280dc0440f97277e37/chrome/browser/media/router/media_router_base.h [modify] https://crrev.com/0ae252e8c2280bacd2d75c280dc0440f97277e37/chrome/browser/media/router/mojo/media_router_mojo_impl.cc [modify] https://crrev.com/0ae252e8c2280bacd2d75c280dc0440f97277e37/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
,
May 12 2016
,
May 12 2016
,
May 16 2016
I'm not seeing this issue in Chrome M51 51.0.2704.47 MR: 5116.418.1.7 is that expected? |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mfo...@chromium.org
, May 10 2016