Detailed breakdown of Reader Mode triggering is needed |
|||||
Issue descriptionVersion: M51 The UMA stats collected in https://codereview.chromium.org/1612803002 (DomDistiller.PageDistillableAfterParsing and DomDistiller.PageDistillableAfterLoading) are not fine-grained enough after the short article rejection (https://codereview.chromium.org/1808503002/) and domain blacklist (https://codereview.chromium.org/1705323004/) are added. The "Non-mobile-friendly, distillable" group of DomDistiller.PageDistillableAfter* is considerably larger than DomDistiller.ReaderShownForPageLoad. The detailed breakdown should show some hints.
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bec86bbd24ae14ff54c99bfed50a3a0206a59cad commit bec86bbd24ae14ff54c99bfed50a3a0206a59cad Author: wychen <wychen@chromium.org> Date: Thu May 12 01:37:28 2016 Record detailed breakdown of Reader Mode triggering BUG= 610794 Review-Url: https://codereview.chromium.org/1965943002 Cr-Commit-Position: refs/heads/master@{#393138} [modify] https://crrev.com/bec86bbd24ae14ff54c99bfed50a3a0206a59cad/components/dom_distiller/content/renderer/distillability_agent.cc [modify] https://crrev.com/bec86bbd24ae14ff54c99bfed50a3a0206a59cad/tools/metrics/histograms/histograms.xml
,
May 16 2016
,
May 16 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea5ce2313904578ca925b0145c16e4a7ab0fa354 commit ea5ce2313904578ca925b0145c16e4a7ab0fa354 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Mon May 16 21:58:06 2016 Record detailed breakdown of Reader Mode triggering BUG= 610794 Review-Url: https://codereview.chromium.org/1965943002 Cr-Commit-Position: refs/heads/master@{#393138} (cherry picked from commit bec86bbd24ae14ff54c99bfed50a3a0206a59cad) Review URL: https://codereview.chromium.org/1984853002 . Cr-Commit-Position: refs/branch-heads/2704@{#568} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/ea5ce2313904578ca925b0145c16e4a7ab0fa354/components/dom_distiller/content/renderer/distillability_agent.cc [modify] https://crrev.com/ea5ce2313904578ca925b0145c16e4a7ab0fa354/tools/metrics/histograms/histograms.xml
,
Sep 6 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by wychen@chromium.org
, May 10 2016