New issue
Advanced search Search tips

Issue 610793 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 590319



Sign in to add a comment

Extension Toolbar Redesign Clean Up: Remove chevron ui code

Project Member Reported by est...@chromium.org, May 10 2016

Issue description

the overflow chevron doesn't exist in the redesigned toolbar
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0b361e58098a446de60b2e911587f9076bd1f25

commit a0b361e58098a446de60b2e911587f9076bd1f25
Author: estade <estade@chromium.org>
Date: Thu May 12 21:54:58 2016

Get rid of some lingering MD-specific raster assets.

Part of this is deleting obsolete bookmark action bar chevron code on Views.

Only pdf.png remains (on Views at least) and I've pinged sgabriel/bettes
for a replacement.

BUG=505953, 610793 
TBR=groby@chromium.org

Review-Url: https://codereview.chromium.org/1971463002
Cr-Commit-Position: refs/heads/master@{#393369}

[rename] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/app/theme/default_100_percent/mac/browser_actions_overflow_hover.png
[rename] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/app/theme/default_100_percent/mac/browser_actions_overflow_normal.png
[rename] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/app/theme/default_100_percent/mac/browser_actions_overflow_pressed.png
[rename] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/app/theme/default_200_percent/mac/browser_actions_overflow_hover.png
[rename] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/app/theme/default_200_percent/mac/browser_actions_overflow_normal.png
[rename] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/app/theme/default_200_percent/mac/browser_actions_overflow_pressed.png
[delete] https://crrev.com/a7bec092422dc5dd11afbecbe720b71df03de077/chrome/app/theme/material_100_percent/common/ash/theme_default_active.png
[delete] https://crrev.com/a7bec092422dc5dd11afbecbe720b71df03de077/chrome/app/theme/material_100_percent/common/ash/theme_default_inactive.png
[rename] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/app/theme/material_100_percent/mac/browser_actions_overflow_normal.png
[delete] https://crrev.com/a7bec092422dc5dd11afbecbe720b71df03de077/chrome/app/theme/material_200_percent/common/ash/theme_default_active.png
[delete] https://crrev.com/a7bec092422dc5dd11afbecbe720b71df03de077/chrome/app/theme/material_200_percent/common/ash/theme_default_inactive.png
[rename] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/app/theme/material_200_percent/mac/browser_actions_overflow_normal.png
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/extensions/browser_action_test_util.h
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/extensions/extension_action_view_controller.cc
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/extensions/extension_action_view_controller.h
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/libgtk2ui/gtk2_ui.cc
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/views/ime/ime_warning_bubble_view.cc
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/views/toolbar/OWNERS
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/views/toolbar/browser_actions_container.h
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
[delete] https://crrev.com/a7bec092422dc5dd11afbecbe720b71df03de077/chrome/browser/ui/views/toolbar/chevron_menu_button.cc
[delete] https://crrev.com/a7bec092422dc5dd11afbecbe720b71df03de077/chrome/browser/ui/views/toolbar/chevron_menu_button.h
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/a0b361e58098a446de60b2e911587f9076bd1f25/ui/views/painter.cc

Comment 2 by est...@chromium.org, May 13 2016

Labels: -OS-Linux -OS-Windows -OS-Chrome
Owner: rdevlin....@chromium.org
Status: Assigned (was: Started)
over to Devlin for mac.
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eb5ed4a472df5b600c76941262bb8e1f86ee41b

commit 9eb5ed4a472df5b600c76941262bb8e1f86ee41b
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Wed May 25 00:46:09 2016

[Extensions UI] Remove all traces of the chevron

BUG= 610793 

Review-Url: https://codereview.chromium.org/2008763002
Cr-Commit-Position: refs/heads/master@{#395756}

[delete] https://crrev.com/0077962d346e9e5d1aa68ddedf540694671db103/chrome/app/theme/default_100_percent/mac/browser_actions_overflow_hover.png
[delete] https://crrev.com/0077962d346e9e5d1aa68ddedf540694671db103/chrome/app/theme/default_100_percent/mac/browser_actions_overflow_normal.png
[delete] https://crrev.com/0077962d346e9e5d1aa68ddedf540694671db103/chrome/app/theme/default_100_percent/mac/browser_actions_overflow_pressed.png
[delete] https://crrev.com/0077962d346e9e5d1aa68ddedf540694671db103/chrome/app/theme/default_200_percent/mac/browser_actions_overflow_hover.png
[delete] https://crrev.com/0077962d346e9e5d1aa68ddedf540694671db103/chrome/app/theme/default_200_percent/mac/browser_actions_overflow_normal.png
[delete] https://crrev.com/0077962d346e9e5d1aa68ddedf540694671db103/chrome/app/theme/default_200_percent/mac/browser_actions_overflow_pressed.png
[delete] https://crrev.com/0077962d346e9e5d1aa68ddedf540694671db103/chrome/app/theme/material_100_percent/mac/browser_actions_overflow_normal.png
[delete] https://crrev.com/0077962d346e9e5d1aa68ddedf540694671db103/chrome/app/theme/material_200_percent/mac/browser_actions_overflow_normal.png
[modify] https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b/chrome/browser/themes/browser_theme_pack.cc
[modify] https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.h
[modify] https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
[modify] https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
[modify] https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b/chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h
[modify] https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
[modify] https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b/chrome/browser/ui/views/toolbar/browser_actions_container.h

Status: Fixed (was: Assigned)

Sign in to add a comment