Issue 610792 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	----
Closed:	Jun 2016
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Feature
Via-Wizard VerifyIn-53 VerifyIn-54 VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Profiling settings cause chromeos-chrome ebuild to die in pkg_postinst

Reported by edward.b...@intel.com, May 10 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Platform: cyan

Steps to reproduce the problem:
$ export CHROME_ORIGIN=LOCAL_SOURCE
$ export EXTRA_BUILD_ARGS="profiling=1 linux_disable_pie=1"
$ export KEEP_CHROME_DEBUG_SYMBOLS=1
$ emerge-${BOARD} chromeos-chrome

What is the expected behavior?
Emerge completes without dying.

What went wrong?
Emerge dies in pkg_postinst due to the chrome binary exceeding 200M.

Did this work before? N/A 

Chrome version: 52.0.2719.0  Channel: n/a
OS Version: 8251.0.2016_05_06_1646 (Test Build - ed)
Flash Version: (Disabled)

Dying in pkg_postinst doesn't actually impact installation. It does however seem to cause confusion :). What do you think about dropping the die to an eerror when keeping chrome symbols?

Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3be9d971931e3ab753bd87ad8894794eb449da36

commit 3be9d971931e3ab753bd87ad8894794eb449da36
Author: Ed Baker <edward.baker@intel.com>
Date: Tue May 03 18:27:22 2016

chromeos-chrome: Log size when keeping symbols

This change uses KEEP_CHROME_DEBUG_SYMBOLS as an indication that big
binaries might be possible. When doing analysis, debugging, or similar
activities Chrome builds can exceed the 200M check added in CL:333879.

BUG= chromium:610792 
TEST=Error message instead of dying when keeping symbols.
$ export CHROME_ORIGIN=LOCAL_SOURCE
$ export EXTRA_BUILD_ARGS="profiling=1 linux_disable_pie=1"
$ export KEEP_CHROME_DEBUG_SYMBOLS=1
$ emerge-${BOARD} chromeos-chrome
    <snip>
    * CHROME_SIZE = 210564904
    * Installed chrome binary got suspiciously large (size=210564904).
    >>> Auto-cleaning packages...
    >>> Using system located in ROOT tree /build/cyan-cheets/
    >>> No outdated packages were found on your system.

Change-Id: I2c6cb5c549bdcdcbbc84fb990bc8a9ababa2174a
Signed-off-by: Ed Baker <edward.baker@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/344000
Commit-Ready: Ilja Friedel <ihf@chromium.org>
Tested-by: Edward Baker <edward.baker@intel.com>
Reviewed-by: Ilja Friedel <ihf@chromium.org>

[modify] https://crrev.com/3be9d971931e3ab753bd87ad8894794eb449da36/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild