New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 610791 link

Starred by 3 users
Status: Fixed
Owner:
kojii@chromium.org
Closed: May 2016
Cc:
kojii@chromium.org
█ ssamanoori@chromium.org
e...@chromium.org
drott@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 155836
issue 605840



Sign in to add a comment

Support includePartialGlyphs=false in Font::offsetForPositionForComplexText

Project Member Reported by kojii@chromium.org, May 10 2016 
This flag was ignored before this patch and is always assumed to be true.

The fix for  issue 591793  worked around of this as the fix was assumed to be short-lived, but hyphens support needs this too, and there seems to be a few more other users.

Comment 1 by kojii@chromium.org, May 10 2016

Blocking: 605840

Comment 2 by kojii@chromium.org, May 11 2016

Cc: drott@chromium.org e...@chromium.org
This might affect line-breaker refactoring. I have a WIP
https://codereview.chromium.org/1966703002
but ellipsis and a few others are relying on this and I need to get them sorted out. From the test results, maybe ellipsis already relies on this being wrong (which will not work with simple path) but I need to look into a bit further.

Comment 3 by kojii@chromium.org, May 11 2016

Blocking: 155836
Project Member

Comment 4 by bugdroid1@chromium.org, May 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad66862296c227c1b74a15f96632a67d941b6643

commit ad66862296c227c1b74a15f96632a67d941b6643
Author: kojii <kojii@chromium.org>
Date: Thu May 12 18:06:38 2016

Support includePartialGlyphs=false in Font::offsetForPositionForComplexText

This patch supports includePartialGlyphs=false in
Font::offsetForPositionForComplexText(). This flag was supported in
offsetForPositionForSimpleText(), but was assumed to be always true in
offsetForPositionForComplexText().

Over 70 existing tests fail by the DCHECK added in this CL without this
fix when the hack in rewindToMidWordBreak() was removed.

BUG= 610791 

Review-Url: https://codereview.chromium.org/1966703002
Cr-Commit-Position: refs/heads/master@{#393300}

[modify] https://crrev.com/ad66862296c227c1b74a15f96632a67d941b6643/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ad66862296c227c1b74a15f96632a67d941b6643/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
[modify] https://crrev.com/ad66862296c227c1b74a15f96632a67d941b6643/third_party/WebKit/Source/platform/fonts/Font.cpp
[modify] https://crrev.com/ad66862296c227c1b74a15f96632a67d941b6643/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp
[modify] https://crrev.com/ad66862296c227c1b74a15f96632a67d941b6643/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.h
[modify] https://crrev.com/ad66862296c227c1b74a15f96632a67d941b6643/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
[modify] https://crrev.com/ad66862296c227c1b74a15f96632a67d941b6643/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h
[modify] https://crrev.com/ad66862296c227c1b74a15f96632a67d941b6643/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp
[modify] https://crrev.com/ad66862296c227c1b74a15f96632a67d941b6643/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h
[modify] https://crrev.com/ad66862296c227c1b74a15f96632a67d941b6643/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultInlineHeaders.h
Project Member

Comment 5 by bugdroid1@chromium.org, May 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3258be53b59b6f872357561176028064ca64784

commit e3258be53b59b6f872357561176028064ca64784
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu May 12 19:18:27 2016

Auto-rebaseline for r393300

https://chromium.googlesource.com/chromium/src/+/ad6686229

BUG= 610791 
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/1970333002 .

Cr-Commit-Position: refs/heads/master@{#393325}

[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/editing/selection/select-text-overflow-ellipsis-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/text-overflow-ellipsis-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/text-overflow-ellipsis-strict-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/text-overflow-ellipsis-text-align-center-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/text-overflow-ellipsis-text-align-center-expected.txt
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/text-overflow-ellipsis-text-align-justify-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/text-overflow-ellipsis-text-align-left-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/text-overflow-ellipsis-text-align-left-expected.txt
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/text-overflow-ellipsis-text-align-right-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/text-overflow-ellipsis-text-align-right-expected.txt
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/text-overflow-input-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/overflow/line-clamp-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/text/ellipsis-ltr-text-in-ltr-flow-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/fast/text/ellipsis-rtl-text-in-ltr-flow-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/android/virtual/spv2/fast/overflow/line-clamp-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-bidi-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-strict-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-center-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-center-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-justify-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-left-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-left-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-right-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-right-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-input-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/line-clamp-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-ltr-flow-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-platform-font-change-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/linux/virtual/spv2/fast/overflow/line-clamp-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/textarea/basic-textareas-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/textarea/basic-textareas-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/textarea/basic-textareas-quirks-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/textarea/basic-textareas-quirks-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-platform-font-change-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/css/text-overflow-ellipsis-text-align-center-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/css/text-overflow-ellipsis-text-align-justify-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/css/text-overflow-ellipsis-text-align-left-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/css/text-overflow-ellipsis-text-align-right-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/textarea/basic-textareas-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/textarea/basic-textareas-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/textarea/basic-textareas-quirks-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-block-with-border-and-padding-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-block-with-border-and-padding-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/forms/textarea/basic-textareas-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/forms/textarea/basic-textareas-quirks-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/line-clamp-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-platform-font-change-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/mac/virtual/spv2/fast/overflow/line-clamp-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-block-with-border-and-padding-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-block-with-border-and-padding-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-text-align-center-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-text-align-center-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-text-align-justify-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-text-align-left-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-text-align-left-expected.txt
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-text-align-right-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/win/fast/overflow/line-clamp-expected.png
[modify] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-platform-font-change-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/win/virtual/spv2/fast/overflow/line-clamp-expected.png
[add] https://crrev.com/e3258be53b59b6f872357561176028064ca64784/third_party/WebKit/LayoutTests/platform/win7/virtual/spv2/fast/overflow/line-clamp-expected.png

Comment 6 by kojii@chromium.org, May 12 2016

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, May 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0834c01dcf4435ade08bfa3e035efd40da0d46c

commit d0834c01dcf4435ade08bfa3e035efd40da0d46c
Author: tapted <tapted@chromium.org>
Date: Fri May 13 00:42:22 2016

Mark virtual/spv2/fast/overflow/line-clamp.html as Failure on Win

This started failing after the Auto-rebaseline for r393300 done in r393325

Link: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/42280

BUG= 610791 
TBR=kojii@chromium.org
NOTRY=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/1974173002
Cr-Commit-Position: refs/heads/master@{#393411}

[modify] https://crrev.com/d0834c01dcf4435ade08bfa3e035efd40da0d46c/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by tapted@chromium.org, May 13 2016

Components: Blink>LayoutTests
Status: Assigned (was: Fixed)
Project Member

Comment 9 by bugdroid1@chromium.org, May 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/473938b5d45c51d1d50a15af26bcd1ae4b924dfe

commit 473938b5d45c51d1d50a15af26bcd1ae4b924dfe
Author: kojii <kojii@chromium.org>
Date: Sat May 14 20:33:53 2016

Manual rebaseline virtual/spv2/fast/overflow/line-clamp.html for Win7

The Auto-rebaseline for r393300 done in r393325 created a separate png
for Win7 from Win, but WebKit Win7 fail since then, matching to the
image for Win.

This patch removes -expected.png for Win7.

BUG= 610791 
TBR=tapted@chromium.org

Review-Url: https://codereview.chromium.org/1984443002
Cr-Commit-Position: refs/heads/master@{#393748}

[modify] https://crrev.com/473938b5d45c51d1d50a15af26bcd1ae4b924dfe/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/080e7e885be49295f8373eb0fa54e6772206bc64/third_party/WebKit/LayoutTests/platform/win7/virtual/spv2/fast/overflow/line-clamp-expected.png

Comment 10 by kojii@chromium.org, May 14 2016

Status: Fixed (was: Assigned)

Comment 11 by sshru...@google.com, May 18 2016

Labels: Test-Layout

Comment 12 by kojii@chromium.org, Jun 13 2016

Cc: ssamanoori@chromium.org kojii@chromium.org
 Issue 546636  has been merged into this issue.
►

Sign in to add a comment