New issue
Advanced search Search tips

Issue 610788 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

compositing/squashing/squash-with-ancestor-blending.html is flaky

Project Member Reported by iclell...@chromium.org, May 10 2016

Issue description

This test has been failing intermittently on several builders.

Flakes:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Fsquashing%2Fsquash-with-ancestor-blending.html&testType=webkit_tests

Recent failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/9888

I'll update the test expectations to indicate flakiness, but the flakes should be fixed if possible.


 
Labels: OS-Windows
Owner: chrishtr@chromium.org
Status: Assigned (was: Available)
It looks like this is currently failing on Windows only (10 and 7), so I'm only marking those ones for now.

Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53944315dd371e821213ba765fa5319ad7cb0c75

commit 53944315dd371e821213ba765fa5319ad7cb0c75
Author: iclelland <iclelland@chromium.org>
Date: Tue May 10 21:03:44 2016

Mark compositing/squashing/squash-with-ancestor-blending.html as flaky

BUG= 610788 
TBR=stanisc
NOTEST=true

Review-Url: https://codereview.chromium.org/1965923002
Cr-Commit-Position: refs/heads/master@{#392716}

[modify] https://crrev.com/53944315dd371e821213ba765fa5319ad7cb0c75/third_party/WebKit/LayoutTests/TestExpectations

Turns out this test and several others are no longer testing anything useful, since
the -expected.html files are exactly the same. This was an accidental problem
introduced when the layer squashing flag was removed.
Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c76c6e041d1b17a721884933ebfacb1d8f6e3666

commit c76c6e041d1b17a721884933ebfacb1d8f6e3666
Author: chrishtr <chrishtr@chromium.org>
Date: Mon Jul 11 16:50:10 2016

Update some squashing tests to actually test squashing vs non-squashing behavior.

Also deflake compositing/squashing/squash-with-ancestor-blending.html.

BUG= 610788 

Review-Url: https://codereview.chromium.org/2132173002
Cr-Commit-Position: refs/heads/master@{#404675}

[modify] https://crrev.com/c76c6e041d1b17a721884933ebfacb1d8f6e3666/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c76c6e041d1b17a721884933ebfacb1d8f6e3666/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-blending-expected.html
[modify] https://crrev.com/c76c6e041d1b17a721884933ebfacb1d8f6e3666/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-blending.html
[modify] https://crrev.com/c76c6e041d1b17a721884933ebfacb1d8f6e3666/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-filter-expected.html
[modify] https://crrev.com/c76c6e041d1b17a721884933ebfacb1d8f6e3666/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-filter.html
[modify] https://crrev.com/c76c6e041d1b17a721884933ebfacb1d8f6e3666/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-mask-expected.html
[modify] https://crrev.com/c76c6e041d1b17a721884933ebfacb1d8f6e3666/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-opacity-expected.html
[modify] https://crrev.com/c76c6e041d1b17a721884933ebfacb1d8f6e3666/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-opacity.html
[modify] https://crrev.com/c76c6e041d1b17a721884933ebfacb1d8f6e3666/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-reflection-expected.html
[modify] https://crrev.com/c76c6e041d1b17a721884933ebfacb1d8f6e3666/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-reflection.html

Sign in to add a comment