Issue metadata
Sign in to add a comment
|
PlzNavigate: browser side mixed-content checks cause a DCHECK in first_web_contents_profiler.cc to be hit |
||||||||||||||||||||||||
Issue descriptionAfter the landing of the initial change to move to the browser process the mixed-content checks for frame-level resources [1], this DCHECK in FirstWebContentsProfiler::DidStartNavigation [2] starts to get triggered when PlzNavigate is enabled: // The first navigation has to be the main frame's. DCHECK(navigation_handle->IsInMainFrame()); To trigger it just execute: cr run chrome --enable-browser-side-navigation https://www.bennish.net/mixed-content.html Note: the same DCHECK exists in FirstWebContentsProfiler::DidFinishNavigation and its implications should also be investigated when resolving this issue. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=599495 [2] https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/metrics/first_web_contents_profiler.cc&q=%22FirstWebContentsProfiler::DidStartNavigation%22&sq=package:chromium&type=cs
,
Aug 19 2016
,
Nov 16 2016
With the changes from https://crrev.com/2448553002 the described DCHECK is now avoided when PlzNavigate is enabled. I ran the documented test locally and got no crash. I'm marking this as fixed and assigning it to jam@ who wrote that patch in the context of issue 650349 .
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by carlosk@chromium.org
, May 10 2016