New issue
Advanced search Search tips

Issue 610771 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 576270



Sign in to add a comment

PlzNavigate: browser side mixed-content checks cause a DCHECK in first_web_contents_profiler.cc to be hit

Project Member Reported by carlosk@chromium.org, May 10 2016

Issue description

After the landing of the initial change to move to the browser process the mixed-content checks for frame-level resources [1], this DCHECK in FirstWebContentsProfiler::DidStartNavigation [2] starts to get triggered when PlzNavigate is enabled:

  // The first navigation has to be the main frame's.
  DCHECK(navigation_handle->IsInMainFrame());

To trigger it just execute:

  cr run chrome --enable-browser-side-navigation https://www.bennish.net/mixed-content.html

Note: the same DCHECK exists in FirstWebContentsProfiler::DidFinishNavigation and its implications should also be investigated when resolving this issue.


[1] https://bugs.chromium.org/p/chromium/issues/detail?id=599495

[2] https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/metrics/first_web_contents_profiler.cc&q=%22FirstWebContentsProfiler::DidStartNavigation%22&sq=package:chromium&type=cs
 
Blocking: 576270
Summary: PlzNavigate: browser side mixed-content checks cause a DCHECK in first_web_contents_profiler.cc to be hit (was: PlzNavigate: browser side mixed-content checks caause a DCHECK in first_web_contents_profiler.cc to be hit)
Components: UI>Browser>Navigation
Owner: jam@chromium.org
Status: Fixed (was: Untriaged)
With the changes from https://crrev.com/2448553002 the described DCHECK is now avoided when PlzNavigate is enabled. I ran the documented test locally and got no crash.

I'm marking this as fixed and assigning it to jam@ who wrote that patch in the context of  issue 650349 .

Comment 4 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 5 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment