Add the ability to show custom content in notifications. Support in C++ interface only at this stage. ddoc: http://go/chrome-custom-notification Googlers, see also: b/28540290 Option B in "Custom Control Support" in: https://docs.google.com/a/google.com/document/d/1tMP3T6JX6os2TObyjMKfJEdZUJ4gPpWDHVDFiMPogFQ/edit?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1c72f97ea348dcf3ffd92966975d4105795fd3d commit f1c72f97ea348dcf3ffd92966975d4105795fd3d Author: xiyuan <xiyuan@chromium.org> Date: Fri May 13 22:24:35 2016 Consolidate to use MessageView - Make factory NotificationView::Create to return MessageView* instead of NotificationView*; - Use MessageView in MessageCenterView and MessagePopupCollection; - Remove MessageViewController and replace it with MessageCenterController; BUG= 610767 Review-Url: https://codereview.chromium.org/1979553003 Cr-Commit-Position: refs/heads/master@{#393663} [modify] https://crrev.com/f1c72f97ea348dcf3ffd92966975d4105795fd3d/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/f1c72f97ea348dcf3ffd92966975d4105795fd3d/ui/message_center/views/message_center_view.h [modify] https://crrev.com/f1c72f97ea348dcf3ffd92966975d4105795fd3d/ui/message_center/views/message_center_view_unittest.cc [modify] https://crrev.com/f1c72f97ea348dcf3ffd92966975d4105795fd3d/ui/message_center/views/message_popup_collection.cc [modify] https://crrev.com/f1c72f97ea348dcf3ffd92966975d4105795fd3d/ui/message_center/views/message_view.cc [modify] https://crrev.com/f1c72f97ea348dcf3ffd92966975d4105795fd3d/ui/message_center/views/message_view.h [modify] https://crrev.com/f1c72f97ea348dcf3ffd92966975d4105795fd3d/ui/message_center/views/notification_view.cc [modify] https://crrev.com/f1c72f97ea348dcf3ffd92966975d4105795fd3d/ui/message_center/views/notification_view.h [modify] https://crrev.com/f1c72f97ea348dcf3ffd92966975d4105795fd3d/ui/message_center/views/notification_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/045c33eb3e2647417ff8c5d8d42c67044b25f7d6 commit 045c33eb3e2647417ff8c5d8d42c67044b25f7d6 Author: xiyuan <xiyuan@chromium.org> Date: Mon May 16 16:59:01 2016 Move close button to MessageView So that it is shared with derived classes. BUG= 610767 Review-Url: https://codereview.chromium.org/1980753002 Cr-Commit-Position: refs/heads/master@{#393849} [modify] https://crrev.com/045c33eb3e2647417ff8c5d8d42c67044b25f7d6/ui/message_center/views/message_view.cc [modify] https://crrev.com/045c33eb3e2647417ff8c5d8d42c67044b25f7d6/ui/message_center/views/message_view.h [modify] https://crrev.com/045c33eb3e2647417ff8c5d8d42c67044b25f7d6/ui/message_center/views/notification_view.cc [modify] https://crrev.com/045c33eb3e2647417ff8c5d8d42c67044b25f7d6/ui/message_center/views/notification_view.h [modify] https://crrev.com/045c33eb3e2647417ff8c5d8d42c67044b25f7d6/ui/message_center/views/notification_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b36c784041e2dd9cd8d953b41dcd997d5be51dae commit b36c784041e2dd9cd8d953b41dcd997d5be51dae Author: xiyuan <xiyuan@chromium.org> Date: Thu May 19 23:09:20 2016 Support notifications with custom content - Add a NOTIFICATION_TYPE_CUSTOM; - Add a NotificationDelegate::CreateCustomContent; - Add a CustomNotificationView for NOTIFICATION_TYPE_CUSTOM that hosts the View created in NotificationDelegate::CreateCustomContent as its contents; BUG= 610767 TEST=CustomNotificationViewTest.* Review-Url: https://codereview.chromium.org/1979583003 Cr-Commit-Position: refs/heads/master@{#394897} [modify] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc [modify] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/chrome/browser/notifications/notification_conversion_helper.cc [modify] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/BUILD.gn [modify] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/message_center.gyp [modify] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/notification_delegate.h [add] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/notification_delegate_views.cc [modify] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/notification_types.h [add] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/views/custom_notification_view.cc [add] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/views/custom_notification_view.h [add] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/views/custom_notification_view_unittest.cc [modify] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/views/message_popup_collection.cc [modify] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/views/message_view.h [add] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/views/message_view_factory.cc [add] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/views/message_view_factory.h [modify] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/views/notification_view.cc [modify] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/views/notification_view.h [modify] https://crrev.com/b36c784041e2dd9cd8d953b41dcd997d5be51dae/ui/message_center/views/notification_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5562d23c289646cfd767d5c2597ad87fc34866e1 commit 5562d23c289646cfd767d5c2597ad87fc34866e1 Author: xiyuan <xiyuan@chromium.org> Date: Wed Jun 15 14:51:26 2016 No paint to layer for custom notification close button BUG= 610767 Review-Url: https://codereview.chromium.org/2066603003 Cr-Commit-Position: refs/heads/master@{#399897} [modify] https://crrev.com/5562d23c289646cfd767d5c2597ad87fc34866e1/ui/message_center/views/custom_notification_view.cc
Comment 1 by bugdroid1@chromium.org
, May 13 2016