New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610760 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 629194



Sign in to add a comment

UrlRequestException should be exposed in RequestFinishedListener#onRequestFinished

Project Member Reported by ashaikh@google.com, May 10 2016

Issue description

Steps to reproduce the problem:
1. Create a CronetEngine and call enableNetworkQualityEstimator followed by addRequestFinishedListener.
2. Create and send a UrlRequest without a network connection.
3. RequestFinishedListener#onRequestFinished(UrlRequestInfo) will be called, but there is no way to access the UrlRequestException from UrlRequestInfo.

What is the expected behavior?
UrlRequestInfo should contain a UrlRequestException field that is populated if the url request failed with an exception.

What went wrong?
Implementation details:
1) Create a mUrlRequestException field in CronetEngine.UrlRequestInfo with a corresponding getter and a constructor that takes in this parameter https://code.google.com/p/chromium/codesearch#chromium/src/components/cronet/android/api/src/org/chromium/net/CronetEngine.java&l=993
2) Create a mUrlRequestException field in CronetUrlRequest and populated it when creating a UrlRequestException in this class
3) In CronetUrlRequest#getRequestInfo, call the constructor created in 1) to populated UrlRequestException with mUrlRequestException

Did this work before? N/A 

Chrome version: 50.0.2661.86  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 21.0 r0
 
Cc: mef@chromium.org
Components: Internals>Network
Status: Untriaged (was: Unconfirmed)

Comment 3 by mef@chromium.org, May 11 2016

Cc: mge...@chromium.org
This should be considered as part of Cronet RequestMetrics API.

Comment 4 by mge...@chromium.org, May 11 2016

Components: -Internals>Network Internals>Network>Library
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 2 2016

Labels: Hotlist-Google
Cc: -mge...@chromium.org
Owner: mge...@chromium.org
Status: Assigned (was: Untriaged)

Comment 7 by sidv@chromium.org, Jun 14 2016

Labels: M-54

Comment 8 by sidv@chromium.org, Jul 18 2016

Labels: MetricsAPI

Comment 9 by mef@chromium.org, Jul 18 2016

Blocking: 629194

Comment 12 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Status: Fixed (was: Assigned)

Sign in to add a comment