UrlRequestException should be exposed in RequestFinishedListener#onRequestFinished |
||||||||||||
Issue descriptionSteps to reproduce the problem: 1. Create a CronetEngine and call enableNetworkQualityEstimator followed by addRequestFinishedListener. 2. Create and send a UrlRequest without a network connection. 3. RequestFinishedListener#onRequestFinished(UrlRequestInfo) will be called, but there is no way to access the UrlRequestException from UrlRequestInfo. What is the expected behavior? UrlRequestInfo should contain a UrlRequestException field that is populated if the url request failed with an exception. What went wrong? Implementation details: 1) Create a mUrlRequestException field in CronetEngine.UrlRequestInfo with a corresponding getter and a constructor that takes in this parameter https://code.google.com/p/chromium/codesearch#chromium/src/components/cronet/android/api/src/org/chromium/net/CronetEngine.java&l=993 2) Create a mUrlRequestException field in CronetUrlRequest and populated it when creating a UrlRequestException in this class 3) In CronetUrlRequest#getRequestInfo, call the constructor created in 1) to populated UrlRequestException with mUrlRequestException Did this work before? N/A Chrome version: 50.0.2661.86 Channel: n/a OS Version: Flash Version: Shockwave Flash 21.0 r0
,
May 11 2016
,
May 11 2016
This should be considered as part of Cronet RequestMetrics API.
,
May 11 2016
,
Jun 2 2016
,
Jun 7 2016
,
Jun 14 2016
,
Jul 18 2016
,
Jul 18 2016
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6caadf0b95430f4d3ae0244bdfb0a6b0b55c24d commit e6caadf0b95430f4d3ae0244bdfb0a6b0b55c24d Author: mgersh <mgersh@chromium.org> Date: Wed Oct 05 19:07:49 2016 Implement exception and finished reason in RequestFinishedInfo BUG= 629194 , 610760 Review-Url: https://codereview.chromium.org/2349973006 Cr-Commit-Position: refs/heads/master@{#423241} [modify] https://crrev.com/e6caadf0b95430f4d3ae0244bdfb0a6b0b55c24d/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java [modify] https://crrev.com/e6caadf0b95430f4d3ae0244bdfb0a6b0b55c24d/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6caadf0b95430f4d3ae0244bdfb0a6b0b55c24d commit e6caadf0b95430f4d3ae0244bdfb0a6b0b55c24d Author: mgersh <mgersh@chromium.org> Date: Wed Oct 05 19:07:49 2016 Implement exception and finished reason in RequestFinishedInfo BUG= 629194 , 610760 Review-Url: https://codereview.chromium.org/2349973006 Cr-Commit-Position: refs/heads/master@{#423241} [modify] https://crrev.com/e6caadf0b95430f4d3ae0244bdfb0a6b0b55c24d/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java [modify] https://crrev.com/e6caadf0b95430f4d3ae0244bdfb0a6b0b55c24d/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 7 2016
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by rtenneti@chromium.org
, May 11 2016Components: Internals>Network