New issue
Advanced search Search tips

Issue 610750 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor resource hints to go through //content

Project Member Reported by csharrison@chromium.org, May 10 2016

Issue description

The resource hints system uses IPCs from component/network_hints/renderer to chrome/browser. The dns / preconnect requests are combined with the predictive requests in chrome/browser/net/predictor.

Instead, we should use mojo to talk to //content directly, bypassing the predictor.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/362027367e6bfd0a4203c030746f41bb74201afb

commit 362027367e6bfd0a4203c030746f41bb74201afb
Author: csharrison <csharrison@chromium.org>
Date: Thu May 12 01:39:49 2016

Effectively disable the predictor's DNS queue for an experiment

This patch lets the predictor send as many requests as it needs to the
host resolver. This is a test to see if the intermediate queues are
really necessary for performance, as they add complexity to the codebase.

BUG=610750

Review-Url: https://codereview.chromium.org/1967663002
Cr-Commit-Position: refs/heads/master@{#393141}

[modify] https://crrev.com/362027367e6bfd0a4203c030746f41bb74201afb/chrome/browser/net/predictor.cc
[modify] https://crrev.com/362027367e6bfd0a4203c030746f41bb74201afb/testing/variations/fieldtrial_testing_config_android.json
[modify] https://crrev.com/362027367e6bfd0a4203c030746f41bb74201afb/testing/variations/fieldtrial_testing_config_linux.json

Project Member

Comment 2 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aef807cd658a84dbe9a2d1fb5a8d69d9d5f3dbd

commit 4aef807cd658a84dbe9a2d1fb5a8d69d9d5f3dbd
Author: csharrison <csharrison@chromium.org>
Date: Thu May 12 20:12:29 2016

Disable features for finch test config of UsePredictorDNSQueue

Pass the "disable_features" param for finch test config.

BUG=610750

Review-Url: https://codereview.chromium.org/1971183002
Cr-Commit-Position: refs/heads/master@{#393340}

[modify] https://crrev.com/4aef807cd658a84dbe9a2d1fb5a8d69d9d5f3dbd/testing/variations/fieldtrial_testing_config_android.json
[modify] https://crrev.com/4aef807cd658a84dbe9a2d1fb5a8d69d9d5f3dbd/testing/variations/fieldtrial_testing_config_linux.json

Project Member

Comment 3 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0597b217f6e2400796536e70ab3413743f4abf80

commit 0597b217f6e2400796536e70ab3413743f4abf80
Author: csharrison <csharrison@chromium.org>
Date: Fri May 27 12:24:04 2016

Move predictor dns unit tests to browser tests

This patch moves some unit tests for the predictor to browser tests. This
is in preparation for a move where the predictor will call out to //content
for preresolve requests.

The patch also refactors how DNS browser tests work, where
we query off the predictor's observer.

BUG=610750, 469120 

Review-Url: https://codereview.chromium.org/1989363007
Cr-Commit-Position: refs/heads/master@{#396444}

[modify] https://crrev.com/0597b217f6e2400796536e70ab3413743f4abf80/chrome/browser/net/predictor.cc
[modify] https://crrev.com/0597b217f6e2400796536e70ab3413743f4abf80/chrome/browser/net/predictor.h
[modify] https://crrev.com/0597b217f6e2400796536e70ab3413743f4abf80/chrome/browser/net/predictor_browsertest.cc
[modify] https://crrev.com/0597b217f6e2400796536e70ab3413743f4abf80/chrome/browser/net/predictor_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f848daf2b342548c8ec90b21396097339688819a

commit f848daf2b342548c8ec90b21396097339688819a
Author: csharrison <csharrison@chromium.org>
Date: Wed Jun 01 21:27:59 2016

Add a Dns preresolve interface in //content

This patch adds a preresolve interface in //content, with the sole
consumer being the predictor in //chrome/browser/net. This is in
preparation for sending resource hints from Blink to //content.

The requests are routed through the ResourceHintsController, which
is scoped to the RDHI. The controller keeps track of each request until
completion, and calls a consumer-supplied callback.

Note: this change also makes all dns preresolves by the predictor use
a lower priority (net::IDLE) than the priority they had previously been
using (net::DEFAULT_PRIORITY).

TBR=kinuko@chromium.org

BUG=610750,614350

Review-Url: https://codereview.chromium.org/2004453002
Cr-Commit-Position: refs/heads/master@{#397250}

[modify] https://crrev.com/f848daf2b342548c8ec90b21396097339688819a/chrome/browser/chromeos/login/auth/auth_prewarmer.cc
[modify] https://crrev.com/f848daf2b342548c8ec90b21396097339688819a/chrome/browser/net/predictor.cc
[modify] https://crrev.com/f848daf2b342548c8ec90b21396097339688819a/chrome/browser/net/predictor.h
[modify] https://crrev.com/f848daf2b342548c8ec90b21396097339688819a/content/browser/loader/resource_hints_impl.cc
[modify] https://crrev.com/f848daf2b342548c8ec90b21396097339688819a/content/public/browser/resource_hints.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4c497067ca404764c5d67df607e894d3118bfae

commit b4c497067ca404764c5d67df607e894d3118bfae
Author: csharrison <csharrison@chromium.org>
Date: Thu Jun 02 18:00:44 2016

Remove references to network_hints::UrlList and network_hints::NameList

This patch removes typedefs from network_hints, in preparation on its
removal (in favor of mojo IPC from Blink to content).

BUG=610750

Review-Url: https://codereview.chromium.org/2038463004
Cr-Commit-Position: refs/heads/master@{#397467}

[modify] https://crrev.com/b4c497067ca404764c5d67df607e894d3118bfae/chrome/browser/net/predictor.cc
[modify] https://crrev.com/b4c497067ca404764c5d67df607e894d3118bfae/chrome/browser/net/predictor.h
[modify] https://crrev.com/b4c497067ca404764c5d67df607e894d3118bfae/chrome/browser/net/predictor_browsertest.cc

Cc: csharrison@chromium.org
Owner: ----
Status: Available (was: Started)
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment