http/tests/serviceworker/chromium/service-worker-mixed-response.html (layout test) fails with multibuffers |
|||||||
Issue descriptionThis test checks that video data can't be combined across different origins in the presence of service workers. When I tried turning multibuffers on on trunk, this test failed. Two other tests failed as well, but I think that's just because they didn't expect the results to be cached. Will deal with them separately.
,
May 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1f791b319a03f4b3a70e8dbaf0bb4c240a86087 commit c1f791b319a03f4b3a70e8dbaf0bb4c240a86087 Author: hubbe <hubbe@chromium.org> Date: Wed May 11 04:29:02 2016 The cross-origin checks in the multibuffer code are not sufficient, as they only trigger when a redirect happens. Service-workers do not need redirects to paste data from diffierent origins together. This CL fixes that. BUG= 610747 Review-Url: https://codereview.chromium.org/1958123004 Cr-Commit-Position: refs/heads/master@{#392850} [modify] https://crrev.com/c1f791b319a03f4b3a70e8dbaf0bb4c240a86087/media/blink/multibuffer_data_source.cc [modify] https://crrev.com/c1f791b319a03f4b3a70e8dbaf0bb4c240a86087/media/blink/multibuffer_data_source_unittest.cc [modify] https://crrev.com/c1f791b319a03f4b3a70e8dbaf0bb4c240a86087/media/blink/resource_multibuffer_data_provider.cc [modify] https://crrev.com/c1f791b319a03f4b3a70e8dbaf0bb4c240a86087/media/blink/resource_multibuffer_data_provider_unittest.cc [modify] https://crrev.com/c1f791b319a03f4b3a70e8dbaf0bb4c240a86087/media/blink/url_index.cc [modify] https://crrev.com/c1f791b319a03f4b3a70e8dbaf0bb4c240a86087/media/blink/url_index.h [modify] https://crrev.com/c1f791b319a03f4b3a70e8dbaf0bb4c240a86087/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/service-worker-mixed-response.html
,
May 11 2016
,
May 17 2016
,
May 17 2016
,
May 17 2016
,
May 17 2016
[Automated comment] Less than 2 weeks to go before stable on M51, manual review required.
,
May 17 2016
Before we approve merge to M51, Could you please confirm whether this bug is baked/verified in Canary and safe to merge?
,
May 18 2016
This also has now backed on canary without issue.
,
May 18 2016
Thank you for confirmation dalecurtis@. Approving merge to M51 branch 2704. Please merge asap.
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87f5415ae750e78664b6f50812bd3fe36665a9fe commit 87f5415ae750e78664b6f50812bd3fe36665a9fe Author: Fredrik Hubinette <hubbe@google.com> Date: Wed May 18 23:42:14 2016 The cross-origin checks in the multibuffer code are not sufficient, as they only trigger when a redirect happens. Service-workers do not need redirects to paste data from diffierent origins together. This CL fixes that. BUG= 610747 Review URL: https://codereview.chromium.org/1993083002 . Cr-Commit-Position: refs/branch-heads/2704@{#596} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/87f5415ae750e78664b6f50812bd3fe36665a9fe/media/blink/multibuffer_data_source.cc [modify] https://crrev.com/87f5415ae750e78664b6f50812bd3fe36665a9fe/media/blink/multibuffer_data_source_unittest.cc [modify] https://crrev.com/87f5415ae750e78664b6f50812bd3fe36665a9fe/media/blink/resource_multibuffer_data_provider.cc [modify] https://crrev.com/87f5415ae750e78664b6f50812bd3fe36665a9fe/media/blink/resource_multibuffer_data_provider_unittest.cc [modify] https://crrev.com/87f5415ae750e78664b6f50812bd3fe36665a9fe/media/blink/url_index.cc [modify] https://crrev.com/87f5415ae750e78664b6f50812bd3fe36665a9fe/media/blink/url_index.h [modify] https://crrev.com/87f5415ae750e78664b6f50812bd3fe36665a9fe/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/service-worker-mixed-response.html |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 Deleted