+msw who has been in the shelf code recently, maybe something is taking focus on click?

+karandeepb, there's also this CL, which isn't particularly recent (April 27) but touches the shelf and involves focus:
https://chromium.googlesource.com/chromium/src.git/+/e7ad02a20c1957caa8a014f17e090dde02573179

I think I've seen this on the mus ash build in the last couple days, so it ought to be easily bisectable. I'm out sick today... Can someone else pick it up? If not, I can look when I'm back in the office.

Ah. Yes, I have seen this as well since yesterday (or Saturday). Was only not getting around filing the issue yet.

I remember that there was recently a CL landed for accessibility (which most likely causes this since it's the accessibility focus border).

glevin@ can you take a quick look here? If you're not able to repro or it's not clear what's happening let me know and we'll figure out plan B.

https://codereview.chromium.org/1958673002/

was the cl I landed. Accessibility highlight is currently behind a flag, so I don't think that was it.

Yeah my CL is the cause for this - https://codereview.chromium.org/1894383002/. I have sent out a patch for review - https://codereview.chromium.org/1963563002/ so this should be fixed soon.

 Issue 610211  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b

commit 8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b
Author: karandeepb <karandeepb@chromium.org>
Date: Mon May 16 01:14:44 2016

Views: Change View::RequestFocus to respect keyboard accessibility.

This CL fixes some regressions introduced in http://crrev.com/1894383002/. These
regression are caused due to the change in View::RequestFocus() from
IsFocusable() to IsAccessibilityFocusable().

On a mouse click on a CustomButton, CustomButton::MousePressed() requests focus
on the button, if it has request_focus_on_press_ set to true. It turns out that
most button subclasses, do not explicitly set request_focus_on_press_ to false,
which has a default value of true. These custom buttons which are accessibility
focusable, can now gain focus on a mouse press, hence the bug.

This CL changes View::RequestFocus to use IsFocusable when keyboard
accessibility is off (i.e on Non-Mac platforms), hence fixing bugs  609701 ,
610186, 610235, 610740, 610802, 610664. This is how View::RequestFocus behaved
before crrev.com/1894383002 on Non-Mac platforms. Also, on Mac, since
View::RequestFocus now respects keyboard accessibility,  bug 611280  is also
fixed.

BUG= 609701 ,  610186 ,  610235 ,  610740 ,  610802 ,  610664 ,  564912 ,  611280 

Review-Url: https://codereview.chromium.org/1973073003
Cr-Commit-Position: refs/heads/master@{#393781}

[modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/chrome/browser/ui/views/tabs/tab_unittest.cc
[modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/ui/views/focus/focus_manager.cc
[modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/ui/views/focus/focus_manager_unittest.cc
[modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/ui/views/view.cc

ChromeOS 8337.0.0, 52.0.2739.0