Mismatch alpha values on the omnibox |
|||||
Issue descriptionThe icons in the omnibox have mismatched alpha values when in incognito mode. See Issue 596036 some more details Note: this issue can't be replicated until https://codereview.chromium.org/1955083003/ has landed
,
May 10 2016
,
May 11 2016
From sgabriel@ The way I designed it was simply 80% opaque, not mixed with black. I'm not sure why Views does things like this but whatever we do, omnibox icons and icons such as back buttons/menu/refresh/etc.. should look the same in term of color. spqchan@: what does color_utils::AlphaBlend(SK_ColorBLACK, text_color, 0x33) return when text_color is SkColorSetA(SK_ColorWHITE, 0xFF)?
,
May 11 2016
It gives me #949494 with 100% alpha
,
May 11 2016
If Views has a different design, perhaps we should just not use DeriveDefaultIconColor on OSX?
,
May 11 2016
and when toolkit is turned off
,
May 11 2016
The only thing is you have to call ContentSettingImageModel::GetIcon() to get the vector icon (or vector_icon_badge_id - not sure what that is)? If we had that we could call CreateVectorIconWithBadge() ourselves, with whatever color we wanted to use. Or do you have a way around that? estade@ wrote DeriveDefaultIconColor() and he sits near me. I was thinking of asking him if it should be returning a transparent color. If he agrees then we just get this function corrected, otherwise we will have to go our own route.
,
May 11 2016
Yeah, we can make a GetIconForMac() method or just have #ifdef(OS_MACOSX) Either way, it's an easy solution Anyway, it's a good idea to ask him about it
,
May 12 2016
Hello spqchan@, I received confirmation from the designer that the icons are supposed to be painted with 0xFFFFFF and 80% opaque, so what Views is doing with the Omnibox icons is incorrect. They will have to fix that at some point, but that will involve changing the opacity of other icons like for the toolbar buttons. You should go ahead and make a change as you suggested (i.e. #if defined(OS_MACOSX) or whatever) to accommodate our needs. When Views makes the fix they can just take that out. Once you land that tweak as part of your decorations cl will you also close out this bug? Thank you.
,
May 12 2016
,
May 12 2016
Sounds good
,
May 12 2016
https://chromium.googlesource.com/chromium/src.git/+/9e77ca29c851bee6722db299074b3dc0a3ba3952
,
May 13 2016
Is there a bug filed about the views issue here? It should be relatively easy to fix this but without a bug it's going to fall on the floor.
,
May 13 2016
Good point, I just created Issue 611617 Issue 611617 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by spqc...@chromium.org
, May 10 2016