New issue
Advanced search Search tips

Issue 610733 link

Starred by 0 users
Status: Fixed
Owner:
cha...@chromium.org
Closed: May 2016
Cc:
feature-...@grotations.appspotmail.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Rename RuntimeEnabledFeatures for origin trials framework

Project Member Reported by cha...@chromium.org, May 10 2016 
There are two runtime features in Blink for the origin trials framework:
- "ExperimentalFramework" to turn on/off the framework in Blink
- "ExperimentalFrameworkSampleAPI" to expose a sample API that is integrated with the framework for tests

In content, there is also a base::Feature for the framework ("kExperimentalFramework").

These artifacts should be changed to be consistent with the origin trials naming.

Comment 1 by cha...@chromium.org, May 10 2016

Owner: cha...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71

commit d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71
Author: chasej <chasej@chromium.org>
Date: Mon May 16 20:59:32 2016

Rename flags for Origin Trials framework

The Blink runtime flags and browser feature are still using the
"Experimental Framework" naming. This CL renames those artifacts to use
the origin trials naming.

BUG= 610733 

Review-Url: https://codereview.chromium.org/1968653002
Cr-Commit-Position: refs/heads/master@{#393909}

[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/chrome/app/generated_resources.grd
[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/chrome/browser/about_flags.cc
[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/content/child/runtime_features.cc
[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/content/public/common/content_features.cc
[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/content/public/common/content_features.h
[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp
[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.cpp
[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.idl
[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/third_party/WebKit/Source/core/origin_trials/testing/WorkerInternalsFrobulate.idl
[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/d55c6f409a41a26eac7a2bd1bb0ed5bfc4026d71/third_party/WebKit/public/web/WebRuntimeFeatures.h

Comment 3 by cha...@chromium.org, May 17 2016

Status: Fixed (was: Started)
►

Sign in to add a comment