New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610730 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
mus



Sign in to add a comment

[meta] Implement mus-gpu to mus-ws window tree updates

Project Member Reported by fsam...@chromium.org, May 10 2016

Issue description

Given the mus-ws, mus-gpu divide, it seems like we don't need nor want cc::Surfacehittest. Instead, we should ship positioning/transform data hanging off SurfaceDrawQuads back to mus-ws. This should be done over a mojo interface.

As a prerequisite, we should try to find a way to avoid using type converters for CompositorFrames (this seems expensive). Right, we piggyback off the typeconverter to extract surface IDs from SurfaceDrawQuads. We should avoid walking the CompositorFrame multiple times I think (maybe?), and instead have a hook from cc/surfaces that lets us observe the walk. Maybe a SurfaceVisitor? Maybe this could be a refactor of SurfaceAggregator?


 
Cc: danakj@chromium.org jbau...@chromium.org
I've already added some security checks to sanitize CompositorFrames wrt mus::Windows. A mus::Window can only refer to other mus::Window surfaces in its subtree. Thus, an arbitrary window cannot move a different arbitrary window. The window manager has the one true view of top level windows, and should not be moving them around using compositor frames, thus a malicious mus-gpu cannot move windows outside of the bounds of a top level window for the purposes of hit testing. Of course, mus-gpu can do other not so nice things, but that's no worse than the current gpu process I believe.
Components: Internals>MUS
Labels: Proj-Mustash
Blocking: 601863
Cc: dtapu...@chromium.org tdres...@chromium.org
Labels: displaycompositor
This bug refers to things that are no longer a problem but the fundamental issue still needs ot be resolved. Window Tree Updates should be pushed from Mus-gpu to Mus-ws. CompositorFrames no longer use type converters. This is very input related so I'm adding a few relevant folks.
Status: WontFix (was: Untriaged)
Based on our latest discussions, I don't believe we want to pursue this architecture in the short term. Closing.
Blocking: -601863
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment