New issue
Advanced search Search tips

Issue 610694 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Create alerts for TBMv2 metrics of v8.infinite_scroll and v8.mobile_infinite_scroll

Project Member Reported by u...@chromium.org, May 10 2016

Issue description

v8.infinite_scroll and v8.mobile_infinite_scroll are converted to TBMv2.

Could you please remove the old alerts and add new alerts for the following metrics?

Animation-v8-gc-latency-mark-compactor_max
Animation-v8-gc-latency-mark-compactor_avg
Animation-v8-gc-latency-mark-compactor_pct_090
Animation-v8-gc-latency-mark-compactor_percentage_idle

Animation-v8-gc-scavenger_max
Animation-v8-gc-scavenger_avg
Animation-v8-gc-scavenger_pct_090
Animation-v8-gc-scavenger_percentage_idle

Animation-v8-gc-incremental-step_max
Animation-v8-gc-incremental-step_pct_090
Animation-v8-gc-incremental-step_avg
Animation-v8-gc-incremental-step_percentage_idle

Animation-v8-gc-incremental-finalize_avg
Animation-v8-gc-incremental-finalize_max
Animation-v8-gc-incremental-finalize_pct_090
Animation-v8-gc-incremental-finalize_percentage_idle

Animation-v8-gc-total_percentage_idle


memory:chrome:renderer:subsystem:v8_avg
memory:chrome:renderer:subsystem:v8_max

memory:chrome:all:subsystem:v8:allocated_objects_avg
memory:chrome:all:subsystem:v8:allocated_objects_max


Thank you!
 
Status: Fixed (was: Assigned)
Done. Note that I added alerts on the individual pages (discourse, facebook, etc) instead of the summary metric. Although this will result in more alerts in total, we feel it is a better approach because:

* We've seen alerts slip through that happen on a single page but are washed away in the average
* The bisect is more accurate on individual pages
* Links to the traces are clearly visible on the tooltips in the chart
* The alert grouping should pull automatically group multiple pages that regress at the same time, so it shouldn't be more sheriffing effort.

Hope that's okay!

Comment 2 by u...@chromium.org, May 10 2016

Thank you, Annie!

I agree that alerts on individual pages are better.

Sign in to add a comment