New issue
Advanced search Search tips

Issue 610674 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.5%-11.7% regression in page_cycler.intl_ko_th_vi at 392390:392439

Project Member Reported by tdres...@chromium.org, May 10 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, May 10 2016

Cc: ccameron@chromium.org
Owner: ccameron@chromium.org

=== Auto-CCing suspected CL author ccameron@chromium.org ===

Hi ccameron@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Make Mac swap code like other platforms
Author  : ccameron
Commit description:
  
Swap buffer completion is sent from the GPU process to the browser
process via the IPC GpuCommandBufferMsg_SwapBuffersCompleted on all
platforms except for Mac, which uses the IPC
GpuHostMsg_AcceleratedSurfaceBuffersSwapped.

Mac needs (for now) to send a handful of additional parameters from the
gpu process at every swap. These parameters are used to display in the
browser process the CALayer tree that is created in the gpu process.
Add these parameters to GpuHostMsg_AcceleratedSurfaceBuffersSwapped
under a platform ifdef. These parameters will be able to be removed when
layer tree construction is moved to be in the browser process.

Pass these parameters along to GpuBrowserCompositorOutputSurface::
SwapBuffers, where they are consumed in Mac-specific code. This wart,
the gpu::GpuProcessHostedCALayerTreeParamsMac structure being passed
along, will be removed when the CALayer tree is constructed in the
browser process.

Swaps are acknowledged by the browser process to the gpu process in the
AcceleratedSurfaceMsg_BufferPresented IPC. The purpose of this IPC was
to send vsync data to the gpu process to coordinate swaps, but this
data is no longer used by the gpu process, is entirely dead code, and
can be removed.

Remove other supporting code that is no longer needed. Not all supporting
code is removed in this patch.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1962493002
Cr-Commit-Position: refs/heads/master@{#392419}
Commit  : 433204258d41867ad95c2af17c1248dfc64032ac
Date    : Mon May 09 20:59:44 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@392411  119.362  5.39815  5   good
chromium@392416  119.401  11.79    12  good
chromium@392418  121.247  10.9602  12  good
chromium@392419  129.385  1.19443  8   bad    <--
chromium@392421  129.226  2.58053  5   bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 610674

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler.morejs
Test Metric: warm_times/page_load_time
Relative Change: 8.26%
Score: 98.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1290
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013048699681977984


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5858564745199616

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
This recovered with r393032

Sign in to add a comment