New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610671 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Card does not peek on tablet for snippets

Project Member Reported by mcwilliams@chromium.org, May 10 2016

Issue description

Need to take into account the tabs
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35826115ac6096ce6d7ce479d966166106d0b01f

commit 35826115ac6096ce6d7ce479d966166106d0b01f
Author: mcwilliams <mcwilliams@chromium.org>
Date: Tue May 10 13:45:01 2016

Add the tabstrip height to the page calculation for peeking card so the card peeks for tablet

BUG= 610671 

Review-Url: https://codereview.chromium.org/1958263003
Cr-Commit-Position: refs/heads/master@{#392589}

[modify] https://crrev.com/35826115ac6096ce6d7ce479d966166106d0b01f/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java

Status: Fixed (was: Started)

Comment 3 by fi...@chromium.org, Jul 1 2016

Labels: zine-mr-MVP

Comment 4 by finkm@google.com, Jul 1 2016

Labels: -zine-mr-mvp

Comment 5 by fi...@chromium.org, Jul 1 2016

Labels: zine-mr-MVP

Sign in to add a comment