Issue metadata
Sign in to add a comment
|
Regression: Weird flickering of Timeline readings is seen after resizing the dev-tool window.
Reported by
jshan...@etouch.net,
May 10 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 52.0.2730.0 (Official Build) 3a85b1c8884d4a28f86a69df86183b51018b8245-refs/heads/master@{#392504} 64 bit. OS: Mac (10.11.4/10.10.5), Retina (10.11.4) Steps: 1. Launch Chrome, open Dev-tool on NTP and go to Timeline section. 2. Check 'Screenshots', 'JS Profile' and complete the recording using Cmd+R key. 3. Now resize the dev-tool window left-right and observe timeline's readings (at CPU) Actual:Weird flickering is seen after resizing the dev-tool window. Expected: No such flickering should be seen after resizing the dev-tool window. This is a regression issue broken in M-52, below is bisect info. Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/994570aa6d910bcf0f0fd54c0beb52b3daf5fe23..5079a895f21988d6983b475874d491f412288678?pretty=fuller&n=100 Suspecting: r391652 ? Please help to reassign if your change is not the cause. Note: This is Mac OS specific issue not seen on Windows and Linux OS.
,
May 10 2016
Marking the above issue as RB-Stable as this is a recent regression. Thank you!
,
May 10 2016
,
May 11 2016
,
May 12 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/a31312cddd51c896b34c5c3382bcf6c50632d70b commit a31312cddd51c896b34c5c3382bcf6c50632d70b Author: ericrk <ericrk@chromium.org> Date: Thu May 12 16:06:44 2016 SkPictureImageFilter - clear local canvas before use In SkPictureImageFilter::onFilterImage, we may create two new surfaces, one for our final output, and one for a local resolution intermediate. We clear the final output surface before use, removing any previous content, however we do not do the same for the local surface. This can lead to content being incorrectly layered on top of previous content when we go down this path. This change adds logic to clear the local surface as well. BUG= 610667 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1969193002 Review-Url: https://codereview.chromium.org/1969193002 [modify] https://crrev.com/a31312cddd51c896b34c5c3382bcf6c50632d70b/src/effects/SkPictureImageFilter.cpp
,
May 12 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/3806b8fb7ffe757cf42f13024dbaf9f24856ccd3 commit 3806b8fb7ffe757cf42f13024dbaf9f24856ccd3 Author: robertphillips <robertphillips@google.com> Date: Thu May 12 17:46:39 2016 Fix bug & add code to catch ImageFilter clearing bugs Follow on to https://codereview.chromium.org/1969193002/ (SkPictureImageFilter - clear local canvas before use) BUG= 610667 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1972213002 Review-Url: https://codereview.chromium.org/1972213002 [modify] https://crrev.com/3806b8fb7ffe757cf42f13024dbaf9f24856ccd3/gm/pictureimagefilter.cpp [modify] https://crrev.com/3806b8fb7ffe757cf42f13024dbaf9f24856ccd3/src/core/SkSpecialSurface.cpp [modify] https://crrev.com/3806b8fb7ffe757cf42f13024dbaf9f24856ccd3/src/effects/SkXfermodeImageFilter.cpp
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4c655a817faf982cdc822b44d536ab5d4316528 commit f4c655a817faf982cdc822b44d536ab5d4316528 Author: skia-deps-roller <skia-deps-roller@chromium.org> Date: Thu May 12 18:58:09 2016 Roll src/third_party/skia/ 97fc9308e..be463bba2 (6 commits). https://chromium.googlesource.com/skia.git/+log/97fc9308e31b..be463bba2ea4 $ git log 97fc9308e..be463bba2 --date=short --no-merges --format='%ad %ae %s' 2016-05-12 herb Fix bad pixel address calculation. 2016-05-12 liyuqian Warning instead of exception for cmake 2016-05-12 halcanary using_skia_and_harfbuzz: compile w/ Android NDK 2016-05-12 bungeman Move SkTypeface to sk_sp. 2016-05-12 liyuqian Use swipe gesture to switch between slides on Android 2016-05-12 ericrk SkPictureImageFilter - clear local canvas before use BUG= 610667 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=scroggo@google.com Review-Url: https://codereview.chromium.org/1973033003 Cr-Commit-Position: refs/heads/master@{#393317} [modify] https://crrev.com/f4c655a817faf982cdc822b44d536ab5d4316528/DEPS
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac83fd18ea2f5e0c226566eb5bd90ffba73efe27 commit ac83fd18ea2f5e0c226566eb5bd90ffba73efe27 Author: skia-deps-roller <skia-deps-roller@chromium.org> Date: Thu May 12 20:03:08 2016 Roll src/third_party/skia/ be463bba2..193d9cf8f (9 commits). https://chromium.googlesource.com/skia.git/+log/be463bba2ea4..193d9cf8f228 $ git log be463bba2..193d9cf8f --date=short --no-merges --format='%ad %ae %s' 2016-05-12 cdalton Eliminate special case nvpr batch handling 2016-05-12 egdaniel Ignore patch version when checking compatibility of vulkan layers 2016-05-12 herb Make PixelGetters much smaller, move more common code to PixelAccessor. 2016-05-12 halcanary cmake: fixes for windows 2016-05-12 robertphillips Make SkGpuBlurUtils::GaussianBlur more drawContext centric 2016-05-12 brianosman Support allowSRGBInputs on Vulkan (via secondary texture views) 2016-05-12 fmalita Remove SkPicture::hasText() 2016-05-12 bungeman Fix typo in SkOSWindow_AndroidNative. 2016-05-12 robertphillips Fix bug & add code to catch ImageFilter clearing bugs BUG= 610667 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=scroggo@google.com Review-Url: https://codereview.chromium.org/1973973003 Cr-Commit-Position: refs/heads/master@{#393339} [modify] https://crrev.com/ac83fd18ea2f5e0c226566eb5bd90ffba73efe27/DEPS
,
May 12 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jshan...@etouch.net
, May 10 2016