Issue metadata
Sign in to add a comment
|
Regression: Loclization issue is seen on Translate bubble.
Reported by
dchau...@etouch.net,
May 10 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:52.0.2730.0 (Official Build)3a85b1c8884d4a28f86a69df86183b51018b8245-refs/heads/master@{#392504} 32/64-bit. OS: Windows(7,8,10). What steps will reproduce the problem? 1. Launch chrome, change browser language to 'Hindi' from 'chrome://settings/addLanguage' and restart the chrome. 2. Now go to any page where translate bubble appears and click on "विकल्प" (Hindi name of 'Options') option on translate bubble and observe. Localization is not applied for 'Always do this' on translate bubble. Localization should applied for 'Always do this' on translate bubble. This is a regression issue, broken in M-52 series, below is bisect info. Good build:52.0.2724.0 Bad build: 52.0.2725.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/9bc4200b07bf658369e23928a6a5412ea909a149..a0c66046550d693ec7f8e86567f9a936e8558521?pretty=fuller&n=10000 Suspecting: r391540 Note: This issue is not seen on Mac and Linux OS. Kindly review the attached screen-cast for reference.
,
May 10 2016
,
May 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed8bfa85a2d506d4ebe5e7b9d1840fe1e59e7d6c commit ed8bfa85a2d506d4ebe5e7b9d1840fe1e59e7d6c Author: ftang <ftang@chromium.org> Date: Tue May 10 21:37:00 2016 create a new message for 'Always do this' instead of using the existing one to avoid localization issue. IDS_TRANSLATE_BUBBLE_ALWAYS was "Always translate" before I land https://chromium.googlesource.com/chromium/src/+/7223e2c7d071d74bcd66c5a113e97fe21a82bb68 in that cl, I change it to "Always do this" but that break the pre-existing localization. So in here I change it back to "Always translate" but create a new one IDS_TRANSLATE_BUBBLE_ALWAYS_DO_THIS for the new one. BUG= 610658 Review-Url: https://codereview.chromium.org/1963183002 Cr-Commit-Position: refs/heads/master@{#392729} [modify] https://crrev.com/ed8bfa85a2d506d4ebe5e7b9d1840fe1e59e7d6c/chrome/app/generated_resources.grd [modify] https://crrev.com/ed8bfa85a2d506d4ebe5e7b9d1840fe1e59e7d6c/chrome/browser/ui/views/translate/translate_bubble_view.cc
,
May 13 2016
Tested the issue on windows 7 using chrome version 52.0.2735.0.Am still seeing the message "Always translate" in english language.Please find the attached screen shot for the same. As per the above fix am not able find the text "Always do this". in the popup. ftang @ Could you please confirm whether the complete fix landed?please provide the steps to verify the fix. Thanks,
,
May 13 2016
I don't know how Chrome l10n process really work. I changed the string and now I change it back but the l10n leveraging didn't pick up the old translation somehow. From here I think the only way to fix it is to let the l10n process to put the right translation in.
,
May 18 2016
Retested the above issue on Windows-7 machine with latest canary 52.0.2739.2 (Official Build). It's seems to fixed and working as intended. i.e. Localization is applied for 'Always do this' on translate bubble. Attaching screen-cast for the reference.
,
May 18 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ashej...@chromium.org
, May 10 2016