Regression : Focus is seen on two options at "More actions" icon in chrome://downloads. |
||||||||||||||
Issue descriptionVersion: 52.0.2730.0 OS: Ubuntu 12.04,14.04,Windows What steps will reproduce the problem? 1. Launch chrome->Download any PDF file 2. Now Navigate to chrome://downloads->Resize browser window for "More actions" icon 3.Now click on "More actions" -> select the "Open Downloads Folder" option and now observe the focus(Please refer Video and Screenshot) Expected: Focus should be seen on selected option at "More actions" icon in chrome://downloads. Actual: Instead Focus is seen on two options This is Regression Issue broken in M-47 Manual good and Bad Builds: Good Build: 47.0.2508.0 Bad Build: 47.0.2509.0 Below is the Bisect info: CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/51739e1843c16705a7c945a237623bdbba728f7e..3035dc3d8583878964dba53bc6e5d3dc8276f1d1 Blink Changelog URL: https://chromium.googlesource.com/chromium/blink/+log/a623cbc..2146135 Suspecting https://codereview.chromium.org/1338953002 from Blink changelog. @yosin: Please feel free to re-assign if its not related to your change
,
May 23 2016
Focus related issue?
,
May 24 2016
I'm not sure this is really the bug in focus handling code in Blink. Without reduced test case, it's really hard to track it down. The bisect info doesn't seem quite useful. Can someone working on MD download page take a stab on what went wrong?
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 9 2016
Hmm, sheriffbot thinks Pri-1 bug a "nonessential bug"? Interesting... Can anyone in material design download UI take a look at this?
,
Jun 30 2016
Anyway, lowering the priority, as this bug is not as critical to prevent some feature working properly. Still looking for someone in MD download page engineers to take a look at this.
,
Jul 10 2016
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12 2016
dbeam@, could you take a look or assign someone?
,
Jul 12 2016
,
Jul 12 2016
probably related to the polymer roll
,
Jul 16 2016
,
Jul 16 2016
bettes@: we need to decide how to show both :focus and :hover. if both make the background gray it's pretty confusing. the only 2 alternative I can think of: 1) drop :hover (what Polymer does) 2) underline on :focus note: bolding on :focus doesn't work well as the dropdown menu is shown with only enough space to fit the text, so if it becomes bold it wraps to 2 lines. I've prepped both solutions here: https://codereview.chromium.org/2155883002/ https://codereview.chromium.org/2157723002/
,
Jul 16 2016
dang, +bettes@/tbuckley@ for real this time read comment 12
,
Jul 19 2016
Sigh. Drop :hover then. True for all drop-downs.
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0934ba457e48ff44d4da6884a960e3b877fc94dd commit 0934ba457e48ff44d4da6884a960e3b877fc94dd Author: dbeam <dbeam@chromium.org> Date: Tue Jul 19 19:14:09 2016 MD Downloads: drop :hover effect because it looks like a lot like :focus R=groby@chromium.org BUG= 610630 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2157723002 Cr-Commit-Position: refs/heads/master@{#406335} [modify] https://crrev.com/0934ba457e48ff44d4da6884a960e3b877fc94dd/chrome/browser/resources/md_downloads/toolbar.css [modify] https://crrev.com/0934ba457e48ff44d4da6884a960e3b877fc94dd/chrome/browser/resources/md_downloads/vulcanized.html
,
Jul 19 2016
,
Sep 29 2017
,
Sep 29 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by kavvaru@chromium.org
, May 10 2016