New issue
Advanced search Search tips

Issue 610625 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-01-26
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression : Settings page does not render properly after selecting 'Show advanced settings..' through 'Enter' key.

Reported by yfulgaon...@etouch.net, May 10 2016

Issue description

Chrome version : 52.0.2730.0 (Official Build) 3a85b1c8884d4a28f86a69df86183b51018b8245-refs/heads/master@{#392504} 32/64 bit
OS :  Windows (7, 8, 10), Linux (14.04 LTS) and Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
1. Launch chrome and go to 'chrome://settings'.
2. Move focus on 'Show advanced settings..' button using Tab key.
3. Hit 'Enter' key and observe.

Actual : Settings page does not render properly after selecting 'Show advanced settings..' through 'Enter' key. 
Expected : Settings page should render properly after selecting 'Show advanced settings..' through 'Enter' key.

This is a regression issue broken in 'M-51' and below is the manual regression and Narrow bisect info:
Good build : 51.0.2700.0
Bad build : 51.0.2702.0

Narrow Bisect info:
https://chromium.googlesource.com/chromium/src/+log/4e980db6a95df1e009038a8efcfe4c16344a6ffd..d831b38d5374391e2b382b465d6d642f519fa9bd?pretty=fuller&n=10000

Suspecting : r385579 from Narrow Bisect
 
Actual_settings.mp4
1.1 MB Download
Expected_settings.mp4
989 KB Download
Labels: ReleaseBlock-Stable
Marking the above issue as RB-Stable, feel free to remove if not required.

Comment 2 by bokan@chromium.org, May 10 2016

Cc: bokan@chromium.org
Labels: -ReleaseBlock-Stable Hotlist-Polish
Owner: ----
Status: Untriaged (was: Assigned)
I think this is a small, polish issue with the settings page. The page calls focus() on the first item in the "advanced" list if the "Show" link was activated via keyboard. This happens after starting an animation to expand the height from 0.

My change made it so that a 0 height box acts as if it were 1 px for the purpose of scrollIntoView. This prevents some degenerate cases and matches Firefox's behavior but I suspect it caused a no-op scrollIntoView to turn into a actual scrollIntoView.

This is something someone on WebUI should fix if deemed important. I managed to fix this just by putting the focus() call into a setTimeout. Calling focus at the end of the animation would be best.
Cc: dbeam@chromium.org
Looks like a small UI issue. The page expands but the animation is janky and afterwards the page is not always scrolled to the "Content settings" button. I still think we should fix it ASAP because of a11y concerns.

Comment 4 by dbeam@chromium.org, May 10 2016

Cc: tbuck...@chromium.org
Labels: -Pri-1 Pri-3
Status: Available (was: Untriaged)

Comment 5 by chaok@google.com, Dec 13 2016

Any update? How can we help to ensure that these accessibility items are fixed for md-settings?

Thanks!
I'm not sure why, in #3, I said we should fix this ASAP... it doesn't seem that problematic, just makes the animation look like it stutters.

MD Settings shows the Advanced section completely differently and doesn't have this problem. The accessibility bug for MD Settings is  issue 603620 .

Comment 7 by chaok@google.com, Jan 26 2017

Labels: Hotlist-MD-Settings-PageA11y
NextAction: 2017-01-26

Comment 8 by chaok@google.com, Jan 26 2017

Labels: Proj-MaterialDesign-WebUI
Cc: -ashej...@chromium.org
Status: WontFix (was: Available)
This refers to the old Settings UI (pre-M59).

Sign in to add a comment