WebTest constructor should not call RegisterWebSchemes as a side-effect |
||
Issue descriptionThis should be done in the test suite. If this requires the WebClient to be set at that point, then it should also be moved there. We may also call RegisterWebSchemes with "false" to allow for other tests to register other schemes if necessary (depending on whether we want to standardize on a single test application scheme(s) in web/ tests or allow tests to register additional schemes). This relates to https://codereview.chromium.org/1929783002.
,
May 12 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/61f7bf0d9371294bd8b5561af7663753cfcdf3b2 commit 61f7bf0d9371294bd8b5561af7663753cfcdf3b2 Author: eugenebut <eugenebut@google.com> Date: Thu May 12 07:34:10 2016
,
May 12 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/7b74575974151c865e3d24fb7ac2ba4ce7e0e00c commit 7b74575974151c865e3d24fb7ac2ba4ce7e0e00c Author: eugenebut <eugenebut@google.com> Date: Thu May 12 17:54:01 2016
,
May 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d195033a24b74413492685d93766932b64ad571e commit d195033a24b74413492685d93766932b64ad571e Author: eugenebut <eugenebut@chromium.org> Date: Tue May 17 17:59:51 2016 [ios] Register test web schemes in WebTestSuite. BUG= 610619 Review-Url: https://codereview.chromium.org/1972903003 Cr-Commit-Position: refs/heads/master@{#394159} [modify] https://crrev.com/d195033a24b74413492685d93766932b64ad571e/ios/web/BUILD.gn [modify] https://crrev.com/d195033a24b74413492685d93766932b64ad571e/ios/web/ios_web.gyp [modify] https://crrev.com/d195033a24b74413492685d93766932b64ad571e/ios/web/test/web_test.mm [modify] https://crrev.com/d195033a24b74413492685d93766932b64ad571e/ios/web/test/web_test_suite.h [rename] https://crrev.com/d195033a24b74413492685d93766932b64ad571e/ios/web/test/web_test_suite.mm
,
May 17 2016
,
May 18 2016
Thank you. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 11 2016