New issue
Advanced search Search tips

Issue 610615 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Update external project zlib to the latest opensource

Reported by jiadong....@linaro.org, May 10 2016

Issue description

Steps to reproduce the problem:
1. chromium uses version 1.2.5 while the latest zlib version is 1.2.8
2. 
3. 

What is the expected behavior?

What went wrong?
Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged to upgrade immediately
Version 1.2.7 has many portability improvements over 1.2.6, and has these enhancements:
Fix bug in gzclose_w() when gzwrite() fails to allocate memory
Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
Add gzopen_w() in Windows for wide character path names
Fix type mismatch between get_crc_table() and crc_table
Version 1.2.6 has many changes over 1.2.5, including these improvements:
gzread() can now read a file that is being written concurrently
gzgetc() is now a macro for increased speed
Added a 'T' option to gzopen() for transparent writing (no compression)
Added deflatePending() to return the amount of pending output
Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw mode
deflatePrime() can now insert bits in the middle of the stream
./configure now creates a configure.log file with all of the results
Added a ./configure --solo option to compile zlib with no dependency on any libraries
Fixed a problem with large file support macros
Fixed a bug in contrib/puff
Many portability improvements

Did this work before? N/A 

Chrome version: 49.0.2623.108  Channel: stable
OS Version: 49.0.2623.108
Flash Version: 49.0.2623.108

refer http://zlib.net/ChangeLog.txt for details
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a50849ae9ba1b2fad47905db521463b3bf085883

commit a50849ae9ba1b2fad47905db521463b3bf085883
Author: jiadong.zhu <jiadong.zhu@linaro.org>
Date: Mon Jun 20 11:09:43 2016

Update Zlib to version 1.2.8

merge the latest open source zlib into chromium external projects

 Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged to upgrade immediately. Version 1.2.8 also has these improvements:
    - Add new inflateGetDictionary() function
    - Fix bug where gzopen() immediately followed by gzclose() would write an empty file instead of an empty gzip stream.
    - Fix bug in gzclose() when gzwrite() runs out of memory
    Version 1.2.7 has many portability improvements over 1.2.6, and has these enhancements:
    - Fix bug in gzclose_w() when gzwrite() fails to allocate memory
    - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
    - Add gzopen_w() in Windows for wide character path names
    - Fix type mismatch between get_crc_table() and crc_table
    Version 1.2.6 has many changes over 1.2.5, including these improvements:
    - gzread() can now read a file that is being written concurrently
    - gzgetc() is now a macro for increased speed
    - Added a 'T' option to gzopen() for transparent writing (no compression)
    - Added deflatePending() to return the amount of pending output
    - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw mode
    - deflatePrime() can now insert bits in the middle of the stream
    - ./configure now creates a configure.log file with all of the results
    - Added a ./configure --solo option to compile zlib with no dependency on any libraries
    - Fixed a problem with large file support macros
    - Fixed a bug in contrib/puff
    - Many portability improvements

BUG= 610615 
R=agl@chromium.org
R=gavinp@chromium.org

Review-Url: https://codereview.chromium.org/1955383002
Cr-Commit-Position: refs/heads/master@{#400647}

[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/AUTHORS
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/net/spdy/spdy_framer_test.cc
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/net/spdy/spdy_session_unittest.cc
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/README.chromium
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/adler32.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/compress.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/contrib/minizip/crypt.h
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/contrib/minizip/ioapi.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/contrib/minizip/ioapi.h
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/contrib/minizip/iowin32.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/contrib/minizip/miniunz.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/contrib/minizip/minizip.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/contrib/minizip/mztools.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/contrib/minizip/mztools.h
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/contrib/minizip/unzip.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/contrib/minizip/unzip.h
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/contrib/minizip/zip.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/crc32.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/crc32.h
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/deflate.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/deflate.h
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/google.patch
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/gzguts.h
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/gzlib.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/gzread.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/gzwrite.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/infback.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/inffast.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/inffixed.h
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/inflate.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/inftrees.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/mixed-source.patch
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/mozzconf.h
[add] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/simd.patch
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/trees.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/uncompr.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/zconf.h
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/zlib.h
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/zutil.c
[modify] https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883/third_party/zlib/zutil.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43770253ccc0425c4edde966e56b3e68955cc4d3

commit 43770253ccc0425c4edde966e56b3e68955cc4d3
Author: jmadill <jmadill@chromium.org>
Date: Mon Jun 20 13:58:52 2016

Revert of Update Zlib to version 1.2.8 (patchset #10 id:220001 of https://codereview.chromium.org/1955383002/ )

Reason for revert:
Broke the Windows Debug GPU FYI builder:

https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder%20%28dbg%29/builds/41421

fx_zlib.gzlib.obj : error LNK2005: _gzopen_w already defined in zlib.gzlib.obj

initial\chrome.dll : fatal error LNK1169: one or more multiply defined symbols found

Possibly because they use shared components with a GYP build.

Original issue's description:
> Update Zlib to version 1.2.8
>
> merge the latest open source zlib into chromium external projects
>
>  Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged to upgrade immediately. Version 1.2.8 also has these improvements:
>     - Add new inflateGetDictionary() function
>     - Fix bug where gzopen() immediately followed by gzclose() would write an empty file instead of an empty gzip stream.
>     - Fix bug in gzclose() when gzwrite() runs out of memory
>     Version 1.2.7 has many portability improvements over 1.2.6, and has these enhancements:
>     - Fix bug in gzclose_w() when gzwrite() fails to allocate memory
>     - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
>     - Add gzopen_w() in Windows for wide character path names
>     - Fix type mismatch between get_crc_table() and crc_table
>     Version 1.2.6 has many changes over 1.2.5, including these improvements:
>     - gzread() can now read a file that is being written concurrently
>     - gzgetc() is now a macro for increased speed
>     - Added a 'T' option to gzopen() for transparent writing (no compression)
>     - Added deflatePending() to return the amount of pending output
>     - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw mode
>     - deflatePrime() can now insert bits in the middle of the stream
>     - ./configure now creates a configure.log file with all of the results
>     - Added a ./configure --solo option to compile zlib with no dependency on any libraries
>     - Fixed a problem with large file support macros
>     - Fixed a bug in contrib/puff
>     - Many portability improvements
>
> BUG= 610615 
> R=agl@chromium.org
> R=gavinp@chromium.org
>
> Committed: https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883
> Cr-Commit-Position: refs/heads/master@{#400647}

TBR=agl@chromium.org,gavinp@chromium.org,khasim.mohammed@linaro.org,jiadong.zhu@linaro.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 610615 

Review-Url: https://codereview.chromium.org/2079313002
Cr-Commit-Position: refs/heads/master@{#400670}

[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/AUTHORS
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/net/spdy/spdy_framer_test.cc
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/net/spdy/spdy_session_unittest.cc
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/README.chromium
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/adler32.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/compress.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/contrib/minizip/crypt.h
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/contrib/minizip/ioapi.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/contrib/minizip/ioapi.h
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/contrib/minizip/iowin32.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/contrib/minizip/miniunz.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/contrib/minizip/minizip.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/contrib/minizip/mztools.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/contrib/minizip/mztools.h
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/contrib/minizip/unzip.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/contrib/minizip/unzip.h
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/contrib/minizip/zip.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/crc32.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/crc32.h
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/deflate.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/deflate.h
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/google.patch
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/gzguts.h
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/gzlib.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/gzread.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/gzwrite.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/infback.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/inffast.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/inffixed.h
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/inflate.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/inftrees.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/mixed-source.patch
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/mozzconf.h
[delete] https://crrev.com/35107e0087ce9ad06d30d2913a14f30991b8d5a7/third_party/zlib/simd.patch
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/trees.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/uncompr.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/zconf.h
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/zlib.h
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/zutil.c
[modify] https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3/third_party/zlib/zutil.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca1c569cff20aa43a42816791744d847c7d788de

commit ca1c569cff20aa43a42816791744d847c7d788de
Author: jiadong.zhu <jiadong.zhu@linaro.org>
Date: Thu Jun 23 04:22:18 2016

Update Zlib to version 1.2.8

merge the latest open source zlib into chromium external projects
Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged to upgrade immediately. Version 1.2.8 also has these improvements:
- Add new inflateGetDictionary() function
- Fix bug where gzopen() immediately followed by gzclose() would write an empty file instead of an empty gzip stream.
- Fix bug in gzclose() when gzwrite() runs out of memory Version 1.2.7 has many portability improvements over 1.2.6, and has these enhancements:
- Fix bug in gzclose_w() when gzwrite() fails to allocate memory
- Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
- Add gzopen_w() in Windows for wide character path names
- Fix type mismatch between get_crc_table() and crc_table Version 1.2.6 has many changes over 1.2.5, including these improvements:
- gzread() can now read a file that is being written concurrently
- gzgetc() is now a macro for increased speed
- Added a 'T' option to gzopen() for transparent writing (no compression)
- Added deflatePending() to return the amount of pending output
- Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw mode
- deflatePrime() can now insert bits in the middle of the stream
- ./configure now creates a configure.log file with all of the results
- Added a ./configure --solo option to compile zlib with no dependency on any libraries
- Fixed a problem with large file support macros
- Fixed a bug in contrib/puff
- Many portability improvements

BUG= 610615  R=gavinp@chromium.org

Review-Url: https://codereview.chromium.org/2084863002
Cr-Commit-Position: refs/heads/master@{#401538}

[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/AUTHORS
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/net/spdy/spdy_framer_test.cc
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/net/spdy/spdy_session_unittest.cc
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/README.chromium
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/adler32.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/compress.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/contrib/minizip/crypt.h
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/contrib/minizip/ioapi.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/contrib/minizip/ioapi.h
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/contrib/minizip/iowin32.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/contrib/minizip/miniunz.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/contrib/minizip/minizip.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/contrib/minizip/mztools.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/contrib/minizip/mztools.h
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/contrib/minizip/unzip.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/contrib/minizip/unzip.h
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/contrib/minizip/zip.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/crc32.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/crc32.h
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/deflate.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/deflate.h
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/google.patch
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/gzguts.h
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/gzlib.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/gzread.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/gzwrite.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/infback.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/inffast.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/inffixed.h
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/inflate.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/inftrees.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/mixed-source.patch
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/mozzconf.h
[add] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/simd.patch
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/trees.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/uncompr.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/zconf.h
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/zlib.h
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/zutil.c
[modify] https://crrev.com/ca1c569cff20aa43a42816791744d847c7d788de/third_party/zlib/zutil.h

Comment 4 by mark@chromium.org, Feb 10 2017

Status: Fixed (was: Unconfirmed)

Sign in to add a comment