Remove duplication in external clear key related test code |
||
Issue descriptionWe have many places where we declare the library name of clearkeycdm(adapter) on different platforms: media/cdm/external_clear_key_test_helper.cc chrome/browser/load_library_perf_test.cc chrome/browser/media/encrypted_media_browsertest.cc chrome/browser/media/encrypted_media_supported_types_browsertest.cc chrome/browser/content_settings/content_settings_browsertest.cc Also we have a lot of duplicate code on how the clearkeycdmadapter is registered as a plugin. We should have a common place for these names to reduce the level of duplication. One option is to have an external_clearkey_cdm_common.h file, similar to widevine_cdm_common.h we have.
,
May 18 2016
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c90dd4e51c054188933aaeffbaceae84f774a18 commit 0c90dd4e51c054188933aaeffbaceae84f774a18 Author: xhwang <xhwang@chromium.org> Date: Wed May 18 16:35:32 2016 Revert of media: Add helper function to register pepper CDMs (patchset #4 id:50008 of https://chromiumcodereview.appspot.com/1983563002/ ) Reason for revert: This make tests fail in official builds: https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%20tester/builds/4758 Original issue's description: > media: Add helper function to register pepper CDMs > > This removes duplicate pepper CDM registration code. > > BUG= 610581 ,582622 > TEST=No functionality change. > > Committed: https://crrev.com/eb61e1d9dde1d6c02919c3716a2fd6729267cbac > Cr-Commit-Position: refs/heads/master@{#394332} TBR=ddorwin@chromium.org,thestig@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 610581 ,582622 Review-Url: https://codereview.chromium.org/1993813002 Cr-Commit-Position: refs/heads/master@{#394440} [modify] https://crrev.com/0c90dd4e51c054188933aaeffbaceae84f774a18/chrome/browser/content_settings/content_settings_browsertest.cc [modify] https://crrev.com/0c90dd4e51c054188933aaeffbaceae84f774a18/chrome/browser/media/encrypted_media_browsertest.cc [modify] https://crrev.com/0c90dd4e51c054188933aaeffbaceae84f774a18/chrome/browser/media/encrypted_media_supported_types_browsertest.cc [delete] https://crrev.com/49142dd682724ad6c3c4d9cc473c01d8a2286644/chrome/browser/media/pepper_cdm_test_helper.cc [delete] https://crrev.com/49142dd682724ad6c3c4d9cc473c01d8a2286644/chrome/browser/media/pepper_cdm_test_helper.h [modify] https://crrev.com/0c90dd4e51c054188933aaeffbaceae84f774a18/chrome/chrome_tests.gypi [modify] https://crrev.com/0c90dd4e51c054188933aaeffbaceae84f774a18/chrome/test/BUILD.gn
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b941714542cb1e29df0c5a7b056bd6eb716708ed commit b941714542cb1e29df0c5a7b056bd6eb716708ed Author: xhwang <xhwang@chromium.org> Date: Wed May 18 22:23:36 2016 (reland) madia: Add helper function to register pepper CDMs This relands commit eb61e1d9dde1d6c02919c3716a2fd6729267cbac with fix. Original CL description: This removes duplicate pepper CDM registration code. Fix: In chrome_content_renderer_client.cc, we whitelist Widevine CDM using the plugin display name. So in content_settings_browsertest.cc I should pass in the corrent display name for Widevine CDM. TBR=thestig@chromium.org,ddorwin@chromium.org BUG= 610581 ,582622 Review-Url: https://codereview.chromium.org/1991963002 Cr-Commit-Position: refs/heads/master@{#394574} [modify] https://crrev.com/b941714542cb1e29df0c5a7b056bd6eb716708ed/chrome/browser/content_settings/content_settings_browsertest.cc [modify] https://crrev.com/b941714542cb1e29df0c5a7b056bd6eb716708ed/chrome/browser/media/encrypted_media_browsertest.cc [modify] https://crrev.com/b941714542cb1e29df0c5a7b056bd6eb716708ed/chrome/browser/media/encrypted_media_supported_types_browsertest.cc [add] https://crrev.com/b941714542cb1e29df0c5a7b056bd6eb716708ed/chrome/browser/media/pepper_cdm_test_helper.cc [add] https://crrev.com/b941714542cb1e29df0c5a7b056bd6eb716708ed/chrome/browser/media/pepper_cdm_test_helper.h [modify] https://crrev.com/b941714542cb1e29df0c5a7b056bd6eb716708ed/chrome/chrome_tests.gypi [modify] https://crrev.com/b941714542cb1e29df0c5a7b056bd6eb716708ed/chrome/test/BUILD.gn |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 18 2016