New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610572 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Mac: Flashing while watching videos

Project Member Reported by ccameron@chromium.org, May 10 2016

Issue description

Version: r392382
OS: Mac

What steps will reproduce the problem?
(1) Go to any site with an embedded YouTube video. YouTube itself seems to do it sometimes, it is also egregious on this page: http://www.vox.com/2016/5/9/11638808/john-oliver-science-studies-last-week-tonight
(2) Play the video, and hover the mouse in and out of the video's frame
(3) Observe that the entire window's contents flash with the wrong content.

See attached video.

A bisect suggested that this range is to blame
https://chromium.googlesource.com/chromium/src/+log/e5a5bbfd2365c4c9f1f6cf97a56f0cd15b1c3132..575a9b96a2b2776a6a4ae81f2e20c2bf3e975250

I could imagine this having to do with the damage or video change. Seeing if local reverts give any insights.
 
Actually attaching the video.
flashing.mov
7.3 MB Download
Cc: -w...@chromium.org
jbauman@, ptal: this regressed in r391733.

When we are using the CoreAnimation renderer, we draw nothing to the OpenGL backbuffer. When we switch to the GL renderer (because a frame cannot be represented using the CoreAnimation renderer), it is required that we re-draw the entire frame.

That is done in overlay_processor_->ProcessForOverlays, where we alter frame.root_damage_rect.

This patch change DirectRenderer::ComputeScissorRectForRenderPass to (I suspect) use frame.root_render_pass.damage_rect and not use frame.root_damage_rect.

Can we kill off frame.root_damage_rect? Redundant information causes problems like this.
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
This has been fixed.

Sign in to add a comment