New issue
Advanced search Search tips

Issue 610554 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Circular dependency in shell:shell_public target

Project Member Reported by eugene...@chromium.org, May 10 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b143c65c2e8b243e54b39359d4509d85f5fa72a

commit 9b143c65c2e8b243e54b39359d4509d85f5fa72a
Author: eugenebut <eugenebut@chromium.org>
Date: Thu May 12 06:26:12 2016

Extracted shell_interfaces and shell_public into a separate gyp file.

This change breaks components/filesystem/filesystem.gyp ->
services/shell/shell.gyp -> components/filesystem/filesystem.gyp
circular dependency which has been introduced here:
https://codereview.chromium.org/1942473002/diff/320001/services/shell/shell.gyp

and breaks runhooks on iOS as follows:
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/2023/steps/gclient%20runhooks%20%28with%20patch%29/logs/stdio

BUG= 610554 

Review-Url: https://codereview.chromium.org/1966563002
Cr-Commit-Position: refs/heads/master@{#393196}

[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/chrome/chrome_browser.gypi
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/components/filesystem/filesystem.gyp
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/components/leveldb/leveldb.gyp
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/content/content_browser.gypi
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/content/content_common.gypi
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/content/content_common_mojo_bindings.gyp
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/content/content_renderer.gypi
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/content/content_tests.gypi
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/content/content_utility.gypi
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/extensions/extensions_tests.gyp
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/media/mojo/interfaces/mojo_bindings.gyp
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/services/shell/shell.gyp
[add] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/services/shell/shell_public.gyp
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/services/tracing/tracing.gyp
[modify] https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a/services/user/user.gyp

Status: Fixed (was: Started)

Sign in to add a comment