[Media Router] Run afterNextRender() before all tests using media-router-container. |
||
Issue descriptionThere's a race condition where afterNextRender() is not always called before setTimeout(). This causes flaky tests. There was a single test that was failing on official bots, but all tests should be run after afterNextRender() is run to ensure setup is complete, including registering listeners. This is currently an issue for tests using media-router-container, as it's the only element to utilise afterNextRender(). Other tests can still use setTimeout().
,
May 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6101899d9c383af3e47801dc11dc594df43555c1 commit 6101899d9c383af3e47801dc11dc594df43555c1 Author: apacible <apacible@chromium.org> Date: Tue May 10 19:04:25 2016 [Media Router WebUI] Run afterNextRender() before tests using media-router-container. There's a race condition where afterNextRender() is not always called before setTimeout(). This causes flaky tests. All tests that use media-router-container, which uses afterNextRender() as part of its setup, should be run after an afterNextRender() call rather than setTimeout(). This will ensure setup completion, including registering listeners. BUG= 610547 Review-Url: https://codereview.chromium.org/1963933002 Cr-Commit-Position: refs/heads/master@{#392668} [modify] https://crrev.com/6101899d9c383af3e47801dc11dc594df43555c1/chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js [modify] https://crrev.com/6101899d9c383af3e47801dc11dc594df43555c1/chrome/test/data/webui/media_router/media_router_container_filter_tests.js [modify] https://crrev.com/6101899d9c383af3e47801dc11dc594df43555c1/chrome/test/data/webui/media_router/media_router_container_first_run_flow_tests.js [modify] https://crrev.com/6101899d9c383af3e47801dc11dc594df43555c1/chrome/test/data/webui/media_router/media_router_container_route_tests.js [modify] https://crrev.com/6101899d9c383af3e47801dc11dc594df43555c1/chrome/test/data/webui/media_router/media_router_container_search_tests.js [modify] https://crrev.com/6101899d9c383af3e47801dc11dc594df43555c1/chrome/test/data/webui/media_router/media_router_container_sink_list_tests.js [modify] https://crrev.com/6101899d9c383af3e47801dc11dc594df43555c1/chrome/test/data/webui/media_router/media_router_header_tests.js [modify] https://crrev.com/6101899d9c383af3e47801dc11dc594df43555c1/chrome/test/data/webui/media_router/media_router_search_highlighter_tests.js
,
May 11 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by apaci...@chromium.org
, May 10 2016