New issue
Advanced search Search tips

Issue 610546 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CertVerifyProcTest.TestKnownRoot and CertVerifyProcTest.PublicKeyHashes disabled.

Project Member Reported by jyqu...@chromium.org, May 10 2016

Issue description

Comments in the code indicate that these tests would start failing on May 9, 2016, and they did. Disabling CertVerifyProcTest.TestKnownRoot and CertVerifyProcTest.PublicKeyHashes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8907f402e6141d88721bb4b4307c8fe8f283c5e

commit f8907f402e6141d88721bb4b4307c8fe8f283c5e
Author: jyquinn <jyquinn@chromium.org>
Date: Tue May 10 01:03:14 2016

Disable CertVerifyProcTest TestKnownRoot and PublicKeyHashes

Comment in TestKnownRoot indicates that it and PublicKeyHashes will
fail on May 9, 2016, and they did. Disabling for now.

BUG= 610546 
TBR=agl@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1959083003
Cr-Commit-Position: refs/heads/master@{#392503}

[modify] https://crrev.com/f8907f402e6141d88721bb4b4307c8fe8f283c5e/net/cert/cert_verify_proc_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2016

Labels: merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a057ee0b468377d8b366dc05e76c57b5300d97e1

commit a057ee0b468377d8b366dc05e76c57b5300d97e1
Author: Jackie Quinn <jyquinn@chromium.org>
Date: Tue May 10 17:38:18 2016

Disable CertVerifyProcTest TestKnownRoot and PublicKeyHashes

Comment in TestKnownRoot indicates that it and PublicKeyHashes will
fail on May 9, 2016, and they did. Disabling for now.

BUG= 610546 
TBR=agl@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1959083003
Cr-Commit-Position: refs/heads/master@{#392503}
(cherry picked from commit f8907f402e6141d88721bb4b4307c8fe8f283c5e)

Review URL: https://codereview.chromium.org/1962363002 .

Cr-Commit-Position: refs/branch-heads/2704@{#477}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/a057ee0b468377d8b366dc05e76c57b5300d97e1/net/cert/cert_verify_proc_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2016

Labels: merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e23f722cebb9f8bb1a722679a184faf377e34ea9

commit e23f722cebb9f8bb1a722679a184faf377e34ea9
Author: Jackie Quinn <jyquinn@chromium.org>
Date: Wed May 11 00:05:43 2016

Disable CertVerifyProcTest TestKnownRoot and PublicKeyHashes

Comment in TestKnownRoot indicates that it and PublicKeyHashes will
fail on May 9, 2016, and they did. Disabling for now.

BUG= 610546 
TBR=agl@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1959083003
Cr-Commit-Position: refs/heads/master@{#392503}
(cherry picked from commit f8907f402e6141d88721bb4b4307c8fe8f283c5e)

Review URL: https://codereview.chromium.org/1963403002 .

Cr-Commit-Position: refs/branch-heads/2661@{#679}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/e23f722cebb9f8bb1a722679a184faf377e34ea9/net/cert/cert_verify_proc_unittest.cc

Comment 4 by eroman@chromium.org, Jun 29 2016

Components: -Internals>Network Internals>Network>Certificate Internals>Network>SSL

Comment 5 by eroman@chromium.org, Jun 29 2016

Issue 624219 has been merged into this issue.
Components: Tests>Disabled
Labels: Test-Disabled
Components: -Internals>Network>SSL
Owner: rsleevi@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6c6a403c112550aa59c3245c179805317c8e2f5

commit d6c6a403c112550aa59c3245c179805317c8e2f5
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Sat Apr 14 01:33:04 2018

Re-enable CertVerifyProcInternalTest.TestKnownRoot

The chain previously used to test this certificate expired two years
ago. Re-enable this test by using the longest lived BR-compliant
certificate I could find, which will hopefully allow delaying updating
until 2021.

BUG= 610546 

Change-Id: I858b7382cb7e4f6ad4bf16d0120080ae4c95fa10
Reviewed-on: https://chromium-review.googlesource.com/1011325
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550851}
[modify] https://crrev.com/d6c6a403c112550aa59c3245c179805317c8e2f5/net/BUILD.gn
[modify] https://crrev.com/d6c6a403c112550aa59c3245c179805317c8e2f5/net/cert/cert_verify_proc_unittest.cc
[modify] https://crrev.com/d6c6a403c112550aa59c3245c179805317c8e2f5/net/data/ssl/certificates/README
[add] https://crrev.com/d6c6a403c112550aa59c3245c179805317c8e2f5/net/data/ssl/certificates/daltonridgeapts.com-chain.pem
[delete] https://crrev.com/9bd1a50ca7a132d6eb582f0fa2674b98b57f9923/net/data/ssl/certificates/twitter-chain.pem

Labels: -merge-merged-2661 -merge-merged-2704 M-68 Target-68
Status: Verified (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6c6a403c112550aa59c3245c179805317c8e2f5

commit d6c6a403c112550aa59c3245c179805317c8e2f5
Author: Ryan Sleevi <rsleevi@chromium.org>
Date: Sat Apr 14 01:33:04 2018

Re-enable CertVerifyProcInternalTest.TestKnownRoot

The chain previously used to test this certificate expired two years
ago. Re-enable this test by using the longest lived BR-compliant
certificate I could find, which will hopefully allow delaying updating
until 2021.

BUG= 610546 

Change-Id: I858b7382cb7e4f6ad4bf16d0120080ae4c95fa10
Reviewed-on: https://chromium-review.googlesource.com/1011325
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550851}
[modify] https://crrev.com/d6c6a403c112550aa59c3245c179805317c8e2f5/net/BUILD.gn
[modify] https://crrev.com/d6c6a403c112550aa59c3245c179805317c8e2f5/net/cert/cert_verify_proc_unittest.cc
[modify] https://crrev.com/d6c6a403c112550aa59c3245c179805317c8e2f5/net/data/ssl/certificates/README
[add] https://crrev.com/d6c6a403c112550aa59c3245c179805317c8e2f5/net/data/ssl/certificates/daltonridgeapts.com-chain.pem
[delete] https://crrev.com/9bd1a50ca7a132d6eb582f0fa2674b98b57f9923/net/data/ssl/certificates/twitter-chain.pem

Sign in to add a comment