New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610520 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove VideoDecodeAccelerator::SetCdm

Project Member Reported by w...@chromium.org, May 9 2016

Issue description

We can pass the Cdm in the config instead.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b0527c03f250052e4cc41356549279d2ebfce9c

commit 8b0527c03f250052e4cc41356549279d2ebfce9c
Author: watk <watk@chromium.org>
Date: Thu May 12 02:29:21 2016

Remove VideoDecodeAccelerator::SetCdm() and pass the cdm in Initialize()

When SetCdm was written we didn't necessarily have the CDM ID when we called
VDA::Initialize(). Now we do, so we can simplify things by removing SetCdm.

BUG= 610520 

Review-Url: https://codereview.chromium.org/1963903002
Cr-Commit-Position: refs/heads/master@{#393150}

[modify] https://crrev.com/8b0527c03f250052e4cc41356549279d2ebfce9c/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/8b0527c03f250052e4cc41356549279d2ebfce9c/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/8b0527c03f250052e4cc41356549279d2ebfce9c/media/gpu/android_video_decode_accelerator.h
[modify] https://crrev.com/8b0527c03f250052e4cc41356549279d2ebfce9c/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/8b0527c03f250052e4cc41356549279d2ebfce9c/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h
[modify] https://crrev.com/8b0527c03f250052e4cc41356549279d2ebfce9c/media/gpu/ipc/common/media_param_traits_macros.h
[modify] https://crrev.com/8b0527c03f250052e4cc41356549279d2ebfce9c/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/8b0527c03f250052e4cc41356549279d2ebfce9c/media/gpu/ipc/service/gpu_video_decode_accelerator.h
[modify] https://crrev.com/8b0527c03f250052e4cc41356549279d2ebfce9c/media/video/video_decode_accelerator.cc
[modify] https://crrev.com/8b0527c03f250052e4cc41356549279d2ebfce9c/media/video/video_decode_accelerator.h

Comment 2 by w...@chromium.org, May 12 2016

Status: Fixed (was: Started)

Sign in to add a comment