New issue
Advanced search Search tips

Issue 610483 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Tests_QuicClientSessionTest.SetFecProtectionFromConfig tests are flaky in official.desktop Precise 64 builder.

Project Member Reported by ligim...@chromium.org, May 9 2016

Issue description

Tests_QuicClientSessionTest.SetFecProtectionFromConfig_1
Tests_QuicClientSessionTest.SetFecProtectionFromConfig_2
Tests_QuicClientSessionTest.SetFecProtectionFromConfig_3
Tests_QuicClientSessionTest.SetFecProtectionFromConfig_4
Tests_QuicClientSessionTest.SetFecProtectionFromConfig_5

Above tests are flaky in Precise64 official desktop builder.

Link to the builder:
===================
https://uberchromegw.corp.google.com/i/official.desktop/builders/precise64/builds/670

Link to the log file:
======================
https://uberchromegw.corp.google.com/i/official.desktop/builders/precise64/builds/670/steps/net_unittests/logs/stdio

Error Log
=========
TTests/QuicClientSessionTest.SetFecProtectionFromConfig/0 (run #1):
[ RUN      ] Tests/QuicClientSessionTest.SetFecProtectionFromConfig/0

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: OnCanWrite()
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.
../../net/tools/quic/quic_client_session_test.cc:249: Failure
Value of: QuicSpdySessionPeer::GetHeadersStream(session_.get())->fec_policy()
  Actual: 1
Expected: FEC_PROTECT_ALWAYS
Which is: 0
[  FAILED  ] Tests/QuicClientSessionTest.SetFecProtectionFromConfig/0, where GetParam() = 30 (122 ms)

Looping to -//src/net/OWNERS for disabling /fixing the tests. 
 
Those tests were removed in https://codereview.chromium.org/1761263002/patch/60001/70032 and FEC is no longer supported.

Should we just set FLAGS_enable_quic_fec false in this build and remove this particular test?

Comment 2 by rch@chromium.org, May 11 2016

Since the test has been removed, does that solve this problem?
Cc: -davidben@chromium.org

Comment 4 by rch@chromium.org, May 13 2016

Owner: ligim...@chromium.org
Assigning back to ligimole@chromium.org please let me know if there is some way I can help here, but since the test has been removed I'm not sure how I can help
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 10 2016

Labels: -M-53 -Pri-1 M-54 MovedFrom-53 Pri-2
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Officialtest officialtest
Status: WontFix (was: Assigned)
Closing as the builds are successful.

https://uberchromegw.corp.google.com/i/official.desktop/builders/precise64/builds/1152

Sign in to add a comment