New issue
Advanced search Search tips

Issue 610479 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[51 Merge Request] Test runner script dependency fix.

Project Member Reported by mikec...@chromium.org, May 9 2016

Issue description

Request to cherry-pick this CL to 51...
https://codereview.chromium.org/1893063002

This CL only fixes the dependencies for some of the gtest targets.
 

Comment 1 by tin...@google.com, May 10 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8111f61175b968fc412fa5eaba3c2c1db4710ee9

commit 8111f61175b968fc412fa5eaba3c2c1db4710ee9
Author: Mike Case <mikecase@google.com>
Date: Wed May 11 22:37:03 2016

[Merge to 51] Make the Android test apks depend on their run_ scripts

The dependency should actually be the other way around, but
for compatibility with GYP, it has to go this way.

Original CL: https://codereview.chromium.org/1893063002

BUG= 610479 
R=dpranke@chromium.org, jbudorick@chromium.org

Review URL: https://codereview.chromium.org/1968773002 .

Cr-Commit-Position: refs/branch-heads/2704@{#508}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/8111f61175b968fc412fa5eaba3c2c1db4710ee9/build/config/android/internal_rules.gni
[modify] https://crrev.com/8111f61175b968fc412fa5eaba3c2c1db4710ee9/testing/test.gni

Status: Fixed (was: Untriaged)

Sign in to add a comment