New issue
Advanced search Search tips

Issue 610478 link

Starred by 1 user
Status: Fixed
Owner:
gogerald@chromium.org
Closed: May 2016
Cc:
ew...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

AddGoogleAccountDialogFragment is unused

Project Member Reported by gogerald@chromium.org, May 9 2016 
Version: TOT
OS: Android

AddGoogleAccountDialogFragment is unused. We use Android add Google account pages instead.

Comment 1 by ew...@chromium.org, May 9 2016 

Just to make sure I understand - is this just cleaning up some unused code?

Comment 2 by gogerald@chromium.org, May 9 2016 

Yes, may be I should not have ccd you,

Comment 3 by ew...@chromium.org, May 9 2016 

No worries, I like knowing about code cleanups we get to do as well :)
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf3395431d65a2462ddc80a6187559a7090a79be

commit bf3395431d65a2462ddc80a6187559a7090a79be
Author: gogerald <gogerald@chromium.org>
Date: Tue May 10 13:48:30 2016

Remove unused AddGoogleAccountDialogFragment

We use Android add Google account pages.

BUG= 610478 

Review-Url: https://codereview.chromium.org/1958953003
Cr-Commit-Position: refs/heads/master@{#392591}

[delete] https://crrev.com/d2fe3e24fcf998b6fcc5d92343fe93cefd90fa04/chrome/android/java/src/org/chromium/chrome/browser/signin/AddGoogleAccountDialogFragment.java
[modify] https://crrev.com/bf3395431d65a2462ddc80a6187559a7090a79be/chrome/android/java_sources.gni

Comment 5 by gogerald@chromium.org, May 10 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment