New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 610464 link

Starred by 2 users
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Dec 2017
Cc:
█ lushnikov@chromium.org
petewil@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

inspector/components/throttler.html is flaky

Project Member Reported by stanisc@chromium.org, May 9 2016 
inspector/components/throttler.html has been failing a lot recently. 
Builder: WebKit Win7 (dbg)

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29?numbuilds=200

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/5589

lushnikov@, since you seem to be familiar with this test, please take a look and reassign as appropriate.

Comment 1 by stanisc@chromium.org, May 9 2016 

--- E:\b\build\slave\WebKit_Win7__dbg_\build\layout-test-results\inspector/components/throttler-expected.txt
+++ E:\b\build\slave\WebKit_Win7__dbg_\build\layout-test-results\inspector/components/throttler-actual.txt
@@ -5,7 +5,7 @@
 Throttler is in IDLE state (doesn't have any timers set up)
 SCHEDULED: 'operation #1' asSoonAsPossible: false
 SCHEDULED: 'operation #2' asSoonAsPossible: undefined
-Throttler is in TIMEOUT state. Scheduled timers timeouts: [1989]
+Throttler is in TIMEOUT state. Scheduled timers timeouts: [0]
 Process 'operation #2' STARTED.
 Process 'operation #2' FINISHED.

Comment 2 by stanisc@chromium.org, May 9 2016

Labels: Sheriff-Chromium
Project Member

Comment 3 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a85b1c8884d4a28f86a69df86183b51018b8245

commit 3a85b1c8884d4a28f86a69df86183b51018b8245
Author: stanisc <stanisc@chromium.org>
Date: Tue May 10 01:12:13 2016

Mark inspector/components/throttler.html as flaky on Win7 Debug

This test has been failing intermittently on Win7 Dbg builder.

TBR=lushnikov@chromium.org
BUG= 610464 

Review-Url: https://codereview.chromium.org/1959233002
Cr-Commit-Position: refs/heads/master@{#392504}

[modify] https://crrev.com/3a85b1c8884d4a28f86a69df86183b51018b8245/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by hayato@chromium.org, May 10 2016

Labels: -Sheriff-Chromium
Status: Assigned (was: Available)
Looks Owner was assigned. Let me remove Sheriff-Chromium label from this issue.

Comment 6 by lushnikov@chromium.org, Jul 8 2016

Cc: petewil@chromium.org lushnikov@chromium.org
 Issue 624422  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b6934dae35ce8c54ace157f0892079908d88175

commit 6b6934dae35ce8c54ace157f0892079908d88175
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Fri Dec 15 04:45:34 2017

DevTools: unflake http/tests/devtools/components/throttler.js

The test was mocking time only partially: the window.performance.now()
should be mocked as well.

BUG= 610464 
TBR=dgozman

Change-Id: If9c81662235e43ee2ffafef2ed772158f3a74968
Reviewed-on: https://chromium-review.googlesource.com/828443
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524327}
[modify] https://crrev.com/6b6934dae35ce8c54ace157f0892079908d88175/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6b6934dae35ce8c54ace157f0892079908d88175/third_party/WebKit/LayoutTests/http/tests/devtools/components/throttler.js
[modify] https://crrev.com/6b6934dae35ce8c54ace157f0892079908d88175/third_party/WebKit/Source/devtools/front_end/common/Throttler.js

Comment 9 by lushnikov@chromium.org, Dec 15 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment