Fractional scroll offfset feature causes jitter during scroll on high-dpi |
|||||||||||
Issue descriptionChrome Version : 51.0.2704.37 OS Version: 8172.25.0 URLs (if applicable) : https://drafts.csswg.org/css-ui-4/ What steps will reproduce the problem? 1. On high-dpi (eg. pixel) 2. Load https://drafts.csswg.org/css-ui-4/ 3. Scroll the main document 4. Watch the table of contents on the left What is the expected result? What happens instead of that? Table of contents jitters up and down while scrolling - presumably by a single physical pixel. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 8172.25.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.37 Safari/537.36 ⛆ |
|
|
,
May 12 2016
,
May 17 2016
Ah, it's occurring only with --enable-experimental-web-platform-features So next step is probably to figure out which feature is triggering this. But that means it's not really a regression and probably not Pri-1.
,
May 17 2016
My money's on FractionalScrollOffsets. :)
,
May 18 2016
Thank you for providing more feedback. Adding requester "bokan@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 19 2016
Assigning to bokan@ for now. Lowering priority since this is an experimental feature.
,
May 19 2016
Related to issue 414283 and issue 456622. What we're doing with fractional scrolling isn't completely clear, but it looks like we'll get all the benefits from issue 485650. So perhaps this blink FractionalScrollOffsets RuntimeEnabledFeature is now dead. I'm going to demote the feature to 'test' or disabled status just to solve this jitter issue while we figure out what we want to do (there are a non-trivial number of people running with experimental web platform features enabled).
,
May 19 2016
Sounds like a good plan. Thanks Rick.
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8591ae927ed0dfafd977121533265d5cbc88a9fe commit 8591ae927ed0dfafd977121533265d5cbc88a9fe Author: rbyers <rbyers@chromium.org> Date: Fri May 27 15:54:36 2016 Disable fractional scroll feature by default This feature is in a half-finished state and has regressed at some point. The primary use case will soon be addressed by bug 485650, we need to figure out what to do about the remaining use cases (eg. scroll while pinch-zoomed). In the interim, don't enable / test the partial code we have for this in blink unless the feature is explicitly enabled. I left support in the tests (though not the expected output files) so that we can easily find the affected tests later when we either resume work on the feature or remove it entirely. BUG=610460, 456622 Review-Url: https://codereview.chromium.org/2005193005 Cr-Commit-Position: refs/heads/master@{#396476} [modify] https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe/third_party/WebKit/LayoutTests/fast/events/scale-and-scroll-div-expected.txt [modify] https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe/third_party/WebKit/LayoutTests/fast/events/scale-and-scroll-div.html [modify] https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe/third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-scaled-expected.txt [modify] https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe/third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html [modify] https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe/third_party/WebKit/LayoutTests/fast/scrolling/fractional-scroll-offset-document-expected.txt [modify] https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe/third_party/WebKit/LayoutTests/fast/scrolling/fractional-scroll-offset-document.html [modify] https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe/third_party/WebKit/LayoutTests/fast/scrolling/scrolling-apis-subpixel-expected.txt [modify] https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe/third_party/WebKit/LayoutTests/fast/scrolling/scrolling-apis-subpixel.html [modify] https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in [modify] https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp [modify] https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
,
May 11 2017
,
Apr 25 2018
|
||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by bokan@chromium.org
, May 11 2016