official 32-bit builds don't work with gn on windows |
||||
Issue description
C:\src\chrome\src>type out\gn\args.gn
is_component_build=true
symbol_level = 1
target_cpu = "x86"
is_official_build = true
is_chrome_branded = true
C:\src\chrome\src>ninja -C out\gn remoting-me2me-host-win.zip
...
[7131/7131] ACTION //remoting/host:remoting_me2me_host_archive(//build/toolchain/win:clang_x86)
FAILED: remoting-me2me-host-win.zip
c:/src/depot_tools/python276_bin/python.exe ../../remoting/host/installer/build-installer-archive.py gen/installation re
moting-me2me-host-win.zip --source-file-roots C:/src/chrome/src/remoting/host/installer/win --source-files C:/src/chrome
/src/remoting/host/installer/win/chromoting.wxs C:/src/chrome/src/remoting/host/installer/win/parameters.json --generate
d-files remote_assistance_host.exe remote_security_key.exe remoting_core.dll remoting_desktop.exe remoting_host.exe remo
ting_native_messaging_host.exe remoting_start_host.exe gen/remoting/CREDITS.txt remoting/com.google.chrome.remote_assist
ance.json remoting/com.google.chrome.remote_desktop.json icudtl.dat ../../third_party/platformsdk_win7/files/Redist/x64/
sas.dll C:/src/chrome/src/remoting/resources/chromoting.ico --generated-files-dst files/remote_assistance_host.exe files
/remote_security_key.exe files/remoting_core.dll files/remoting_desktop.exe files/remoting_host.exe files/remoting_nativ
e_messaging_host.exe files/remoting_start_host.exe files/CREDITS.txt files/com.google.chrome.remote_assistance.json file
s/com.google.chrome.remote_desktop.json files/chromoting.ico files/icudtl.dat files/sas.dll --defs BRANDING=Chrome DAEMO
N_CONTROLLER_CLSID=ccd05487-f566-5926-9b83-851b2ed50a11 RDP_DESKTOP_SESSION_CLSID=e6cca603-663b-5288-8094-8ab2c27b7092 V
ERSION=52.0.2724.0 OFFICIAL_BUILD=1
Traceback (most recent call last):
File "../../remoting/host/installer/build-installer-archive.py", line 292, in <module>
sys.exit(main())
File "../../remoting/host/installer/build-installer-archive.py", line 286, in main
defs)
File "../../remoting/host/installer/build-installer-archive.py", line 207, in buildHostArchive
shutil.copy2(bs, dst_file)
File "c:\src\depot_tools\python276_bin\lib\shutil.py", line 130, in copy2
copyfile(src, dst)
File "c:\src\depot_tools\python276_bin\lib\shutil.py", line 82, in copyfile
with open(src, 'rb') as fsrc:
IOError: [Errno 2] No such file or directory: '../../third_party/platformsdk_win7/files/Redist/x64/sas.dll'
ninja: build stopped: subcommand failed.
I'll take a look.
,
May 9 2016
turned out to be trivial: https://codereview.chromium.org/1963813002/
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a48f12399989d45a23bcf830087d15cd1c95a601 commit a48f12399989d45a23bcf830087d15cd1c95a601 Author: thakis <thakis@chromium.org> Date: Mon May 09 22:10:13 2016 gn/win: Make remoting build in official 32-bit builds. BUG= 610445 , 512899 TBR=sergeyu NOTRY=true Review-Url: https://codereview.chromium.org/1963813002 Cr-Commit-Position: refs/heads/master@{#392440} [modify] https://crrev.com/a48f12399989d45a23bcf830087d15cd1c95a601/remoting/host/BUILD.gn
,
May 9 2016
,
May 9 2016
There is more broken: C:\src\chrome\src>ninja -C out\gn -k 0 ninja: Entering directory `out\gn' [3/9] ACTION //remoting/host:remoting_host_installation(//build/toolchain/win:clang_x86) FAILED: chromoting.msi c:/src/depot_tools/python276_bin/python.exe ../../remoting/tools/zip2msi.py --wix_path C:/src/chrome/src/third_party/wix --intermediate_dir gen/installation --target_arch x86 remoting-me2me-host-win.zip chromoting.msi Invalid target_arch parameter value ninja: build stopped: cannot make progress due to previous errors.
,
May 9 2016
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bd26f185bdbf8762bf69cdc6b4d8834e5e2b968 commit 7bd26f185bdbf8762bf69cdc6b4d8834e5e2b968 Author: thakis <thakis@chromium.org> Date: Mon May 09 23:46:00 2016 win/gn: Make building chromoting.msi work in 32-bit official builds. BUG= 610445 , 512899 TBR=sergeyu Review-Url: https://codereview.chromium.org/1962913002 Cr-Commit-Position: refs/heads/master@{#392478} [modify] https://crrev.com/7bd26f185bdbf8762bf69cdc6b4d8834e5e2b968/remoting/host/BUILD.gn
,
May 10 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by thakis@chromium.org
, May 9 2016