[MD settings] subpages no longer expand 100% verically |
||
Issue descriptionOpen chrome://md-settings. Click on something that will open a sub-page, such as Manage Search Engines. The sub-page does not expand to the full height of the window. This appears to be introduced by https://codereview.chromium.org/1950423003
,
May 9 2016
adding to my plate with the other animation glitches
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f55deb67c516167728a79cc29c7a00771c7c1b9c commit f55deb67c516167728a79cc29c7a00771c7c1b9c Author: michaelpg <michaelpg@chromium.org> Date: Mon May 09 23:51:26 2016 MD Settings: Page and animation fixes Fixes the sub-pages not expanding to 100%. Also fixes the scroll height of main pages, which was too high due to the vertical margin (most noticeable in About). Stops sections from disappearing as soon as the expand animation begins. R=dpapad@chromium.org BUG= 610429 , 608598 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1965553002 Cr-Commit-Position: refs/heads/master@{#392480} [modify] https://crrev.com/f55deb67c516167728a79cc29c7a00771c7c1b9c/chrome/browser/resources/settings/settings_page.css [modify] https://crrev.com/f55deb67c516167728a79cc29c7a00771c7c1b9c/chrome/browser/resources/settings/settings_page/main_page_behavior.html [modify] https://crrev.com/f55deb67c516167728a79cc29c7a00771c7c1b9c/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
,
May 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa50bdb702230dbec1bfa0f7a830e93066056af6 commit fa50bdb702230dbec1bfa0f7a830e93066056af6 Author: michaelpg <michaelpg@chromium.org> Date: Tue May 10 01:21:37 2016 MD Settings: Fix minor vertical jumps in animations This fixes glitches in the section-subpage expand/collapse animations. I wrote up a much longer description but git ate it. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation BUG= 610429 R=dpapad@chromium.org Review-Url: https://codereview.chromium.org/1962943002 Cr-Commit-Position: refs/heads/master@{#392505} [modify] https://crrev.com/fa50bdb702230dbec1bfa0f7a830e93066056af6/chrome/browser/resources/settings/settings_page/main_page_behavior.js [modify] https://crrev.com/fa50bdb702230dbec1bfa0f7a830e93066056af6/chrome/browser/resources/settings/settings_page/settings_subpage.html
,
May 17 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by dpa...@chromium.org
, May 9 2016